-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve safe creation status screen #3778
Conversation
Branch preview✅ Deploy successful! Storybook: |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success1409 tests passing in 195 suites. Report generated by 🧪jest coverage report action from ce37ab4 |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Eighteen Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
14c6471
to
c03e4be
Compare
346fb29
to
85c42ea
Compare
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Beyond the comments I made, the rest looks fine. Regarding this comment in the Notion doc: I'm not 100% in removing the "creation done" modal that used to show what the user can do with the safe and also not fully sold about dumping the user into the safe as it is being deployed. I don't think the user will start to navigate the UI as it sees that the safe is deploying with all those loaders. My suggestion would be to show a modal saying "your safe is being deployed, it might take a few minutes, on the meanwhile you can still explore it". And if the safe is deployed then you show the "Your safe has been deployed: [ADDRESS]" modal. |
@francovenica thanks for testing! I pushed a fix to address the issues you found. Could you try again?
You are talking about this screen right? We should document why we want to remove it. cc @TanyaEfremova From my understanding it overloads the user with information about what they can do with their Safe while also blocking them from those actions and essentially forcing them to do an onboarding which can be frustrating. Removing this dialog also affects one of our e2e tests (smoke/create_safe_cf) so we would have to remove |
# Conflicts: # src/components/new-safe/create/logic/index.ts
ESLint Summary View Full Report
Report generated by eslint-plus-action |
I think, we agreed to show the success screen with the account address and a welcoming text instead of this one. I don't think, the current screen provides a lot of error. We also have another success screen for CF accounts, which is completely different from this one, so they need to be aligned anyway, there is no reason in keeping both. |
Yes, exactly! Before, we had a modal with the overview, when an account was created, then once the CF account is deployed a different modal was shown, and the overview wasn't. So we would like to merge them, and only show the one you posted on the screenshot :) So you are correct. |
Ok, Given Tanya's comment and a talk I had with Usame I see that this success screen is the only one and correct. I was afraid I was missing some success screen somewhere LGTM, we can pass this ticket to done |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
What it solves
Resolves #3612
How this PR fixes it
Back to homepage
Try again
Try again
StatusStepper
useSafeCreation
useSafeCreationEffects
CreationModal
and instead shows the new Success screen with the address attachedToDos
safeViewRedirectURL
on SUCCESSHow to test it
Screenshots
Screen.Recording.2024-05-31.at.15.36.17.mov
Checklist