Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Safe creation] Improve the status screen #3612

Closed
6 tasks
usame-algan opened this issue Apr 25, 2024 · 3 comments · Fixed by #3778
Closed
6 tasks

[Safe creation] Improve the status screen #3612

usame-algan opened this issue Apr 25, 2024 · 3 comments · Fixed by #3778
Assignees
Labels
enhancement New feature or request safe-creation

Comments

@usame-algan
Copy link
Member

usame-algan commented Apr 25, 2024

What is the feature about

The status screen when creating a safe has multiple UX issues as documented here and #1484, #1871, Slack

The list of requirements

  • Only move to the status screen once the user has confirmed the transaction in their wallet
  • Rework the Retry and Cancel button
  • Retry should navigate the user back to the review screen with the previous setup filled out
  • Cancel should take the user back to the welcome page
  • Remove the stepper and instead only show the a "Check Status" link for the block explorer
  • Show a clear pending state in the UI and inform the user about the status of their transaction

Designs/sketches

Links

@usame-algan usame-algan added enhancement New feature or request safe-creation labels Apr 25, 2024
@schmanu
Copy link
Member

schmanu commented May 14, 2024

I think when tackling this we should also fix #1330

My best guess is that we wait for the safeTxHash. We should detect that it is a safeTxHash and poll that tx or always poll the SafeInfo additionally.

@usame-algan usame-algan changed the title [Safe creation] Skip the status screen [Safe creation] Improve the status screen May 30, 2024
@usame-algan
Copy link
Member Author

I think when tackling this we should also fix #1330

My best guess is that we wait for the safeTxHash. We should detect that it is a safeTxHash and poll that tx or always poll the SafeInfo additionally.

I haven't tested it yet but I think with the changes implemented in #3778 the user would now simply wait on the status screen without a timeout until the safe has executed the creation. We use the same global hook to monitor the txHash as we do for counterfactual safes so we should become aware of the transaction being executed.

@usame-algan
Copy link
Member Author

Just tested #1330 again on this PR and can confirm that it doesn't work when signing but not executing the transaction in the parent safe. The tx monitor is trying to poll for the txHash (which is actually the safeTxHash) which it can't find so it errors out after a while. We could detect this as @schmanu suggests and in that case poll for either the safe info or the safeTxHash through our services.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request safe-creation
Projects
Archived in project
2 participants