Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add event label to google login button #2786

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Nov 9, 2023

What it solves

Currently we cannot differentiate between a click on the Google login button in the navigation bar or on our welcome page.

How this PR fixes it

Adds an event label which is either "welcome or

How to test it

Click on login with google button in header and welcome page and observe different event labels.

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Nov 9, 2023

Branch preview

✅ Deploy successful!

https://tracking_label_connect_google--walletweb.review-wallet-web.5afe.dev

Copy link

github-actions bot commented Nov 9, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Nov 9, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.08% (+0.01% 🔼)
10092/13441
🔴 Branches
49.61% (-0.01% 🔻)
2051/4134
🔴 Functions 57.53% 1498/2604
🟡 Lines
76.65% (+0.01% 🔼)
9128/11908
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / index.tsx
80.6% (+0.29% 🔼)
72.22% (-2.78% 🔻)
60%
85.25% (+0.25% 🔼)

Test suite run success

1105 tests passing in 155 suites.

Report generated by 🧪jest coverage report action from d3b0d0b

@schmanu schmanu merged commit 33e9826 into dev Nov 9, 2023
13 checks passed
@schmanu schmanu deleted the tracking-label-connect-google branch November 9, 2023 17:17
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants