chore: add event label to google login button (#2786)

* chore: add event label to google login button * fix: additional requested analytics changes
safe-global · Nov 9, 2023 · 33e9826 · 33e9826
1 parent 06f78a1
commit 33e9826
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/src/components/common/SocialSigner/index.tsx b/src/components/common/SocialSigner/index.tsx
@@ -63,6 +63,8 @@ export const SocialSigner = ({
   const userInfo = socialWalletService?.getUserInfo()
   const isDisabled = loginPending || !isMPCLoginEnabled
 
+  const isWelcomePage = !!onLogin
+
   const recoverPassword = useCallback(
     async (password: string, storeDeviceFactor: boolean) => {
       if (!socialWalletService) return
@@ -143,7 +145,7 @@ export const SocialSigner = ({
             </Button>
           </Track>
         ) : (
-          <Track {...MPC_WALLET_EVENTS.CONNECT_GOOGLE}>
+          <Track {...MPC_WALLET_EVENTS.CONNECT_GOOGLE} label={isWelcomePage ? 'welcomePage' : 'navBar'}>
             <Button
               variant="outlined"
               onClick={login}

diff --git a/src/services/analytics/events/mpcWallet.ts b/src/services/analytics/events/mpcWallet.ts
@@ -10,14 +10,19 @@ export const MPC_WALLET_EVENTS = {
   },
   MANUAL_RECOVERY: {
     event: EventType.META,
-    action: 'Account recovery started',
+    action: 'MFA login started',
     category: MPC_WALLET_CATEGORY,
   },
   RECOVER_PASSWORD: {
     event: EventType.CLICK,
     action: 'Recover account using password',
     category: MPC_WALLET_CATEGORY,
   },
+  RECOVERED_SOCIAL_SIGNER: {
+    event: EventType.META,
+    action: 'Recovered social signer',
+    category: MPC_WALLET_CATEGORY,
+  },
   UPSERT_PASSWORD: {
     event: EventType.CLICK,
     action: 'Set or change password',

diff --git a/src/services/mpc/SocialWalletService.ts b/src/services/mpc/SocialWalletService.ts
@@ -45,7 +45,7 @@ class SocialWalletService implements ISocialWalletService {
       }
 
       if (!this.isMFAEnabled()) {
-        trackEvent(MPC_WALLET_EVENTS.ENABLE_MFA)
+        trackEvent({ ...MPC_WALLET_EVENTS.ENABLE_MFA, label: 'password' })
         // 2. enable MFA in mpcCoreKit
         await this.mpcCoreKit.enableMFA({}, false)
       }
@@ -128,6 +128,10 @@ class SocialWalletService implements ISocialWalletService {
       await this.finalizeLogin()
     }
 
+    if (this.mpcCoreKit.status === COREKIT_STATUS.LOGGED_IN) {
+      trackEvent({ ...MPC_WALLET_EVENTS.RECOVERED_SOCIAL_SIGNER, label: 'password' })
+    }
+
     return this.mpcCoreKit.status === COREKIT_STATUS.LOGGED_IN
   }