Release 1.22.0 #2783

schmanu · 2023-11-09T15:18:00Z

Features

Seedless-onboarding (Epic Seedless-onboarding #2534)

Bug Fixes

redirect /wc URL (Fix: redirect /wc URL #2747)

Chores

Optimize docker image (Optimize docker image #2771)

Tests

Add safe apps tests (Tests: Add safe apps tests #2751)
Update workflow to enable tests run in parallel (Tests: Update workflow to enable tests run in parallel #2739)
Make tests independent

* Update workflow to enable tests run in parallel * Update workflow of Safe Apps to run in parallel

* Add safe apps. Fix balance pagination * Update test definitions * Update tooltip expecation in Assets tests

- Reduce size by using multistage builds - Run `yarn build` on the build process and not when the docker image starts (it can take a few minutes to complete)

* fix: Remove WC onboarding tooltip * fix: Onboard Safe logo size * fix: Update e2e tests acceptCookies call * fix: Failing e2e test

* Fix: redirect /wc URL * Use raw URL query * Fix tests * Rm raw query parsing * Fix: unblock Base and Arbitrum bridges in WC

- Adds option to create a social signer via google - Adds Settings page for setting up MFA via password recovery for Social signer - Redesigns Welcome Page --------- Co-authored-by: Usame Algan <[email protected]> Co-authored-by: Usame Algan <[email protected]> Co-authored-by: Michael <[email protected]> Co-authored-by: katspaugh <[email protected]>

github-actions · 2023-11-09T15:18:17Z

Branch preview

✅ Deploy successful!

https://release1220--walletweb.review-wallet-web.5afe.dev

github-actions · 2023-11-09T15:21:42Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

github-actions · 2023-11-09T15:24:58Z

Coverage report

St.^❔	Category	Percentage	Covered / Total
🟡	Statements	75.04% (-0.14% 🔻)	10109/13472
🔴	Branches	49.54% (+0.07% 🔼)	2055/4148
🔴	Functions	57.46% (-0.46% 🔻)	1498/2607
🟡	Lines	76.61% (-0.24% 🔻)	9145/11937

Show new covered files 🐣

St.^❔	File	Statements	Branches	Functions	Lines
🔴	`...` / SocialLoginModule.ts	58.46%	30%	62.5%	57.89%
🟢	`...` / useMPC.ts	91.67%	92.31%	71.43%	93.02%
🔴	`...` / useSocialWallet.ts	45.45%	0%	0%	41.03%
🟡	`...` / SocialWalletService.ts	60%	50%	46.15%	61.11%
🟡	`...` / SecurityQuestionRecovery.ts	60%	0%	75%	60%
🟢	`...` / mpcWallet.ts	100%	100%	100%	100%
🔴	`...` / DeviceShareRecovery.ts	41.67%	0%	60%	41.67%
🟡	`...` / config.ts	63.16%	53.85%	50%	62.5%
🔴	`...` / PasswordRecoveryModal.tsx	32.14%	0%	0%	40.91%
🟢	`...` / PasswordRecovery.tsx	91.3%	100%	50%	95.24%
🟢	`...` / PasswordInput.tsx	80%	42.86%	33.33%	87.5%
🔴	`...` / NoAssets.tsx	53.85%	0%	0%	58.33%
🟢	`...` / index.tsx	80.6%	72.73%	60%	85.25%
🔴	`...` / wallets.ts	35.19%	0%	0%	44.19%
🟢	`...` / wallet.ts	100%	100%	100%	100%
🟢	`...` / eip1193Provider.ts	100%	100%	100%	100%
🟢	`...` / index.tsx	86.49%	77.78%	60%	90.63%
🟢	`...` / index.tsx	100%	30%	100%	100%
🟢	`...` / index.tsx	84.21%	16.67%	50%	87.5%
🟢	`...` / icon.ts	100%	100%	100%	100%
🟢	`...` / WalletLogin.tsx	100%	100%	100%	100%
🟢	`...` / index.tsx	100%	100%	100%	100%
🟢	`...` / index.tsx	100%	100%	100%	100%
🔴	`...` / index.tsx	49.35%	13.33%	9.09%	52.11%
🟡	`...` / index.tsx	55.56%	0%	0%	71.43%
🟢	`...` / index.tsx	80%	100%	0%	100%
🔴	`...` / index.tsx	44.78%	19.35%	27.27%	46.77%
🟢	`...` / AccountCenter.tsx	94.44%	100%	100%	100%
🟢	`...` / index.tsx	94.74%	66.67%	100%	100%
🟢	`...` / ConnectionCenter.tsx	85.19%	66.67%	40%	91.67%
🟡	`...` / ConnectWalletButton.tsx	77.78%	100%	50%	75%
🟢	`...` / WalletDetails.tsx	100%	100%	0%	100%

Show files with reduced coverage 🔻

St.^❔	File	Statements	Branches	Functions	Lines
🔴	`...` / utils.ts	51.22% (-4.88% 🔻)	36.36%	28.57% (-7.14% 🔻)	51.72% (-3.45% 🔻)
🔴	`...` / ExecuteForm.tsx	40.98% (-0.95% 🔻)	0%	0%	41.67% (-0.96% 🔻)
🟡	`...` / useConnectWallet.ts	66.67% (-10.26% 🔻)	0% (-100% 🔻)	50%	63.64% (-11.36% 🔻)
🟡	`...` / index.tsx	72.55% (-1.68% 🔻)	58.33% (-3.57% 🔻)	53.33%	73.2% (-1.8% 🔻)
🟢	`...` / index.tsx	96.15% (+0.15% 🔼)	71.43% (-10.39% 🔻)	76.92%	96% (+0.17% 🔼)
🟢	`...` / useWalletConnectSearchParamUri.ts	92.86% (-7.14% 🔻)	100% (+10% 🔼)	100%	100%
🔴	`...` / index.tsx	58.23%	15% (-0.79% 🔻)	27.27%	58.11%
🟢	`...` / index.ts	100%	66.67% (-33.33% 🔻)	100%	100%

Test suite run success

1105 tests passing in 155 suites.

Report generated by 🧪jest coverage report action from f3fc362

schmanu · 2023-11-09T15:27:35Z

We cannot merge this yet.
We want to include the following PRs to this release which are currently in QA:
#2782
#2778

* chore: add event label to google login button * fix: additional requested analytics changes

francovenica · 2023-11-10T04:37:04Z

Issue:

If you are connected with WC (using a MM phone app) and then, with the social login you change your password, after the page refreshes, the WC new feature shows that the safe is connected to itself

Login with WC using the MM phone app
Connect with social login
Change your password
See how the page refreshes itself
Check the WC feature in the topbar
Change wallet from social login back to WC and check the address

In this gif I was already connected with WC using a MM phone app, then switched to social login and changed the password

* fix: Add ramp view to assets page if there are no assets * fix: Only show ramp button if ramp app is enabled * fix: Wait for connected wallet in batch tx e2e test

* Update test IDs

usame-algan · 2023-11-10T10:49:14Z

If you are connected with WC (using a MM phone app) and then, with the social login you change your password, after the page refreshes, the WC new feature shows that the safe is connected to itself

This is strange, I can't reproduce it. Can you show an example of the whole flow starting from when you connect WC to MM app?

liliya-soroka · 2023-11-10T11:28:40Z

The error in case of paying from the social login address when not enough balance. The error text is unexpected and says nothing to the user

* fix: Adjust overview widget on dashboard for new design * fix: Adjust dashboard e2e test * fix: Icon colors in dark mode * fix: Loading state and mobile view * fix: Mobile button alignment

* chore: add event label to google login button * fix: additional requested analytics changes

usame-algan · 2023-11-10T13:21:42Z

If you are connected with WC (using a MM phone app) and then, with the social login you change your password, after the page refreshes, the WC new feature shows that the safe is connected to itself

This is strange, I can't reproduce it. Can you show an example of the whole flow starting from when you connect WC to MM app?

After doing it together I can also reproduce this issue on prod. The steps are as following:

Open a Safe where your MM mobile app is an owner
Connect via WC to that safe
Observe the correct address in the header
Reload the page
Observe WC shows the safe address

Since this also happens on prod I suggest to create a separate issue

francovenica · 2023-11-10T13:37:53Z

So the issue with WC had nothing to do with seedless or the password, it was just the refreshing of the page. Also the issue is already in prod.
Still I'd like to see if we can fix it now so it can go live soon
Here's a ticket for it

#2790
cc @usame-algan

francovenica · 2023-11-10T14:54:42Z

I've checked the mergin of the tickets regarding assets widget in the dashboard and banner in the assets tab. Also checked the fix on the dashboard assets widget for mobile viewport.
Those look good

francovenica · 2023-11-13T03:06:19Z

The RC looks good.

Notes:

I think is agreed that the issue of WC will be tackled in a different ticket and released later. I'm ok with that. Hopefully we can release it as a stand alone "hot fix" during the week.
We got the RC about the warning of running out of relayer usage. If that one is merged we should take a quick look after
It was mentioned that the "Buy token" button in the dashboard widget for mobile has a small style issue. Usame said he has to fix that one

katspaugh · 2023-11-13T09:19:42Z

@usame-algan will adjust the staging config.

* Fix: show relays even when 0 relays left * Do not show block if relaying not enabled at all * Restore default option to Relay * Restore version

liliya-soroka · 2023-11-13T10:06:13Z

Update: RPC was changed on Gnosis chain . Now works quicker and better
I have an issue in the case of switching between the Goerli and Gnosis chains when social login is used.

Screen.Recording.2023-11-13.at.11.03.19.mov

liliya-soroka · 2023-11-13T11:32:19Z

QR code should be changed if the prefix is off

mike10ca and others added 7 commits November 2, 2023 16:29

Tests: Make tests independent (#2736)

23fe875

Tests: Update workflow to enable tests run in parallel (#2739)

cb5da93

* Update workflow to enable tests run in parallel * Update workflow of Safe Apps to run in parallel

Tests: Add safe apps tests (#2751)

2fce8de

* Add safe apps. Fix balance pagination * Update test definitions * Update tooltip expecation in Assets tests

Chore: Optimize docker image (#2771)

af97244

- Reduce size by using multistage builds - Run `yarn build` on the build process and not when the docker image starts (it can take a few minutes to complete)

fix: Remove WC onboarding tooltip (#2746)

e72f222

* fix: Remove WC onboarding tooltip * fix: Onboard Safe logo size * fix: Update e2e tests acceptCookies call * fix: Failing e2e test

Fix: redirect /wc URL (#2747)

b2ba82d

* Fix: redirect /wc URL * Use raw URL query * Fix tests * Rm raw query parsing * Fix: unblock Base and Arbitrum bridges in WC

schmanu added 2 commits November 9, 2023 17:50

fix: pending state for social login (#2785)

06f78a1

chore: add event label to google login button (#2786)

33e9826

* chore: add event label to google login button * fix: additional requested analytics changes

usame-algan and others added 2 commits November 10, 2023 10:18

fix: Add ramp view to assets page if there are no assets (#2778)

d458c4e

* fix: Add ramp view to assets page if there are no assets * fix: Only show ramp button if ramp app is enabled * fix: Wait for connected wallet in batch tx e2e test

Tests: Update testids (#2784)

a9ce0c1

* Update test IDs

usame-algan force-pushed the release1220 branch from 33e9826 to 2cecaaa Compare November 10, 2023 10:43

usame-algan and others added 2 commits November 10, 2023 12:34

fix: Adjust overview widget on dashboard for new design (#2782)

5399c1a

* fix: Adjust overview widget on dashboard for new design * fix: Adjust dashboard e2e test * fix: Icon colors in dark mode * fix: Loading state and mobile view * fix: Mobile button alignment

chore: add event label to google login button (#2786)

ef79593

* chore: add event label to google login button * fix: additional requested analytics changes

usame-algan force-pushed the release1220 branch from 2cecaaa to ef79593 Compare November 10, 2023 11:36

fix: Hydration error on the NFTs page (#2788)

dc9d022

Merge branch 'dev' of github.com:5afe/web-core into release1220

a5535fc

Fix: show relays even when 0 relays left (#2791)

ba0ffde

* Fix: show relays even when 0 relays left * Do not show block if relaying not enabled at all * Restore default option to Relay * Restore version

1.22.0

d95a943

fix: different configs for staging and prod

937dabb

Fix: prefix switch for receive QR (#2795)

f3fc362

katspaugh merged commit f3fc362 into main Nov 13, 2023
9 of 11 checks passed

katspaugh deleted the release1220 branch November 13, 2023 13:05

github-actions bot locked and limited conversation to collaborators Nov 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 1.22.0 #2783

Release 1.22.0 #2783

schmanu commented Nov 9, 2023

github-actions bot commented Nov 9, 2023 •

edited

Loading

github-actions bot commented Nov 9, 2023 •

edited

Loading

github-actions bot commented Nov 9, 2023 •

edited

Loading

schmanu commented Nov 9, 2023

francovenica commented Nov 10, 2023 •

edited

Loading

usame-algan commented Nov 10, 2023

liliya-soroka commented Nov 10, 2023

usame-algan commented Nov 10, 2023

francovenica commented Nov 10, 2023

francovenica commented Nov 10, 2023

francovenica commented Nov 13, 2023

katspaugh commented Nov 13, 2023

liliya-soroka commented Nov 13, 2023 •

edited

Loading

liliya-soroka commented Nov 13, 2023

Release 1.22.0 #2783

Release 1.22.0 #2783

Conversation

schmanu commented Nov 9, 2023

Features

Bug Fixes

Chores

Tests

github-actions bot commented Nov 9, 2023 • edited Loading

Branch preview

github-actions bot commented Nov 9, 2023 • edited Loading

ESLint Summary View Full Report

github-actions bot commented Nov 9, 2023 • edited Loading

Coverage report

Test suite run success

schmanu commented Nov 9, 2023

francovenica commented Nov 10, 2023 • edited Loading

usame-algan commented Nov 10, 2023

liliya-soroka commented Nov 10, 2023

usame-algan commented Nov 10, 2023

francovenica commented Nov 10, 2023

francovenica commented Nov 10, 2023

francovenica commented Nov 13, 2023

katspaugh commented Nov 13, 2023

liliya-soroka commented Nov 13, 2023 • edited Loading

liliya-soroka commented Nov 13, 2023

github-actions bot commented Nov 9, 2023 •

edited

Loading

github-actions bot commented Nov 9, 2023 •

edited

Loading

github-actions bot commented Nov 9, 2023 •

edited

Loading

francovenica commented Nov 10, 2023 •

edited

Loading

liliya-soroka commented Nov 13, 2023 •

edited

Loading