-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Seedless Onboarding] QA fixes #2721
Changes from 6 commits
3f312d9
ad4cfbb
39bf3b3
31b20e6
f69f536
356b40b
eb48a9c
0ffaf62
8959da8
8a40409
85139e9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,7 +32,7 @@ | |
display: none; | ||
} | ||
|
||
.socialLoginInfo > div > div { | ||
.socialLoginInfo > div > div:last-child { | ||
display: none; | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,8 +20,8 @@ const useSyncSafeCreationStep = (setStep: StepRenderProps<NewSafeFormData>['setS | |
return | ||
} | ||
|
||
// Jump to connect wallet step if there is no wallet and no pending Safe | ||
if (!wallet) { | ||
// Jump to the welcome page if there is no wallet and no pending Safe | ||
if (!wallet && !pendingSafe) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This has no effect because the above condition returns if There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this also doesn't fix the original issue when reloading the page since both wallet and pendingSafe are undefined at the start so the user always gets redirected back. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. After discussion I have reverted this change again. We could also remove the hook from the status screen but I think currently it does no harm. |
||
router.push({ pathname: AppRoutes.welcome.index, query: router.query }) | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test case is a duplicate of "should go to the fourth step if there is a pending safe"
We could add the expectation not to call mockPushRoute to that test case.