[Seedless Onboarding] QA fixes #2721
Conversation
Branch preview⏳ Deploying a preview site... |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Coverage report
Show files with reduced coverage 🔻
Test suite run success1094 tests passing in 152 suites. Report generated by 🧪jest coverage report action from 8a40409 |
| // Jump to connect wallet step if there is no wallet and no pending Safe | ||
| if (!wallet) { | ||
| // Jump to the welcome page if there is no wallet and no pending Safe | ||
| if (!wallet && !pendingSafe) { |
There was a problem hiding this comment.
This has no effect because the above condition returns if pendingSafe is defined.
The new test case also passes without this.
There was a problem hiding this comment.
I think this also doesn't fix the original issue when reloading the page since both wallet and pendingSafe are undefined at the start so the user always gets redirected back.
There was a problem hiding this comment.
After discussion I have reverted this change again. We could also remove the hook from the status screen but I think currently it does no harm.
| @@ -39,6 +39,20 @@ describe('useSyncSafeCreationStep', () => { | |||
| expect(mockPushRoute).toHaveBeenCalledWith({ pathname: AppRoutes.welcome.index, query: undefined }) | |||
| }) | |||
|
|
|||
| it('should not go to the first step if no wallet is connected but there is a pending safe', async () => { | |||
There was a problem hiding this comment.
This test case is a duplicate of "should go to the fourth step if there is a pending safe"
We could add the expectation not to call mockPushRoute to that test case.
What it solves
Part of #2452
How this PR fixes it
Security&Loginpage to the global preferences navigationScreenshots
Checklist