Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Seedless Onboarding] Only continue to safe creation if login succeeds #2714

Merged
merged 2 commits into from
Oct 31, 2023
Merged

[Seedless Onboarding] Only continue to safe creation if login succeeds #2714

merged 2 commits into from
Oct 31, 2023

Conversation

usame-algan
Copy link
Member

What it solves

Part of #2452

How this PR fixes it

  • Checks for wallets.length since onboard returns an empty array if no wallet is connected

How to test it

  1. Open the welcome page
  2. Press Connect wallet
  3. Close the modal
  4. Observe no flashing

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@github-actions
Copy link

github-actions bot commented Oct 31, 2023 •
edited
Loading

Branch preview

✅ Deploy successful!

https://fix_login--walletweb.review-wallet-web.5afe.dev

schmanu
schmanu reviewed Oct 31, 2023
View reviewed changes
Copy link
Member

@schmanu schmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved too soon.
There is a test for this component. We should add a new test case for this.

schmanu
schmanu approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@schmanu schmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usame-algan usame-algan merged commit 4d2a81a into web3authcoresdk Oct 31, 2023
2 of 6 checks passed
@usame-algan usame-algan deleted the fix-login branch October 31, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schmanu schmanu schmanu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@usame-algan @schmanu