[Seedless Onboarding] Only continue to safe creation if login succeeds (

#2714)

* fix: Only continue to safe creation if login succeeds

* fix: Add new test case

src/components/welcome/WelcomeLogin/WalletLogin.tsx

@@ -12,7 +12,8 @@ const WalletLogin = ({ onLogin }: { onLogin: () => void }) => {
 
   const login = async () => {
     const walletState = await connectWallet()
-    if (walletState) {
+
+    if (walletState && walletState.length > 0) {
       onLogin()
     }
   }

src/components/welcome/WelcomeLogin/__tests__/WalletLogin.test.tsx

@@ -68,4 +68,27 @@ describe('WalletLogin', () => {
       expect(mockOnLogin).toHaveBeenCalled()
     })
   })
+
+  it('should not invoke the callback if connection fails', async () => {
+    const mockOnLogin = jest.fn()
+    jest.spyOn(useConnectWallet, 'default').mockReturnValue(jest.fn().mockReturnValue([]))
+
+    const result = render(<WalletLogin onLogin={mockOnLogin} />)
+
+    await waitFor(() => {
+      expect(result.findByText('Connect wallet')).resolves.toBeDefined()
+    })
+
+    // We do not automatically invoke the callback as the user did not actively connect
+    expect(mockOnLogin).not.toHaveBeenCalled()
+
+    act(() => {
+      const button = result.getByRole('button')
+      button.click()
+    })
+
+    await waitFor(() => {
+      expect(mockOnLogin).not.toHaveBeenCalled()
+    })
+  })
 })