Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.14.0 #2219

Merged
merged 20 commits into from
Jul 5, 2023
Merged

Release 1.14.0 #2219

merged 20 commits into from
Jul 5, 2023

Conversation

katspaugh
Copy link
Member

🐞 Bug fixes

🎁 Improvements

dependabot bot and others added 18 commits June 23, 2023 07:17
Bumps [semver](https://github.com/npm/node-semver) from 7.3.8 to 7.5.2.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md)
- [Commits](npm/node-semver@v7.3.8...v7.5.2)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Docs: fix readme formatting

The env vars table was broken

* Move Redefine API URL to env vars

* REDEFINE_REQUEST_URL -> REDEFINE_API
* Fix: reset tx list pages when Safe is changed

* Add the same fix for PaginatedMsgs
* fix: onboard warning colours

* fix: revert palette + remove element

* fix: remove comment

* fix: colours

* fix: remove condition
* fix: upgrade `@web3-onboard/*` + remove patches

* fix: mocks
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Branch preview

✅ Deploy successful!

https://release_1_14_0--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@francovenica
Copy link
Contributor

#2221
I cannot connect with ledger directly in prod so I cannot see if this issue is already happening there.

@francovenica
Copy link
Contributor

I'm seeing this error in polygon when I reach the review step of safe creation. It happens with any wallet.
The error is different in this RC and prod. I don't know if it worth having its own ticket:

RC:
image

Prod:
image

@schmanu
Copy link
Member

schmanu commented Jul 4, 2023

@francovenica
I cannot reproduce that error in the RC. Can you still reproduce it? Otherwise it could have been a temporary RPC problem.

@liliya-soroka
Copy link
Member

@JagoFigueroa to check Safe Apps before the release

@liliya-soroka
Copy link
Member

@francovenica , keystone checked - works as expected

@francovenica
Copy link
Contributor

The comment I made about polygon showing an error in the console when reaching the review step doesn't happen anymore, so it seems it was a temporary issue

@francovenica
Copy link
Contributor

The rest of the RC is fine (tickets listed and regression)

I still have the issue of creating safes in Polygon ( I was able to do it on ETH once).

@schmanu
Copy link
Member

schmanu commented Jul 5, 2023

I found a small bug in our Execute transaction modal (for a fully signed tx):

The "Execute Transaction"-checkbox is disabled (as expected) but not checked.
Screenshot 2023-07-05 at 09 25 28

This happens on the RC but not in prod.

@usame-algan
Copy link
Member

The "Execute Transaction"-checkbox is disabled (as expected) but not checked.

Should be fixed now.

@katspaugh katspaugh merged commit 9809612 into main Jul 5, 2023
9 checks passed
@katspaugh katspaugh deleted the release/1.14.0 branch July 5, 2023 12:18
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2023
@katspaugh
Copy link
Member Author

The Ledger+Polygon issue will be solved separately since it touches on more than just Ledger.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants