Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check execute checkbox if execution is the only option #2230

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Jul 5, 2023

What it solves

Fixes a regression found here

How this PR fixes it

  • Keeps the execute checkbox checked if execution is the only option

How to test it

  1. Open a 1/1 Safe
  2. Create a new transaction
  3. Uncheck the execute checkbox and queue the transaction
  4. Go to the queue
  5. Execute the transaction
  6. Observe the checkbox is checked

Screenshots

Screenshot 2023-07-05 at 10 24 01

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@usame-algan usame-algan requested a review from schmanu July 5, 2023 08:24
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Branch preview

✅ Deploy successful!

https://execute_checkbox--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@usame-algan usame-algan requested a review from iamacook July 5, 2023 08:26
@usame-algan usame-algan merged commit 0c7276b into dev Jul 5, 2023
7 checks passed
@usame-algan usame-algan deleted the execute-checkbox branch July 5, 2023 11:21
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants