-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow access to other XML docs in docx file like the header and footer #73
base: master
Are you sure you want to change the base?
Conversation
ad67fc8
to
990de9c
Compare
990de9c
to
46beee1
Compare
👋 Is there anything holding up this PR from merging? Anything we can do to help? |
This PR would solve a problem I am currently encoutering (namely: setting a bookmark in a header). I am willing to help to get this PR merged, what is holding this back? |
There is a conflict file now. @yjukaku do you have time to resolve the conflict? |
So I was trying if I could get it working, I see the main difference now is that for Office365 files we have to either try So I created a local version, where more inline with the current code, instead of iterating over But when trying to adapt the |
I was trying to DRY the code with the
I personally would expect the document file name to be the same as the original when updated. It appears the better way to find the proper document name would be to check the file See http://officeopenxml.com/anatomyofOOXML.php under Content Types Here's a sample
|
Inspired by PR ruby-docx#73 we adapted the code to work on top of the current state.
Can we merge this PR as well? I need access to numbering and header/footer. Thanks. |
Thanks, the proposed change seems good at a high level to me. (I'm not affiliated with the project, just someone who has started using the library.) This would be helpful for one case I saw today where the important text information we wanted was in the document footer. Right now that information is inaccessible. I wouldn't want to delay this PR, but what do you think about adding the header or footer contents to methods like |
inspired from ruby-docx#73 but stripped down to just the header to see if that might be more amenable to get in. Also because of the TODO note in the update function, only supports reading these files, not updating them.
Any update on this? I've been waiting for it for more than a year now. |
This adds support for retrieving all of the header and footer documents embedded in the docx file, as well as the numbering docs.
This is based on the work in #22 and #42.
It also closes #49 and #32