Use Zip::File#glob to match any document.xml
#104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satoryu
reviewed
May 4, 2021
| @@ -30,8 +30,7 @@ def initialize(path_or_io, options = {}) | |||
| @zip = Zip::File.open_buffer(path_or_io) | |||
| end | |||
|
|
|||
| document = @zip.find_entry('word/document.xml') | |||
| document ||= @zip.find_entry('word/document2.xml') | |||
| document = @zip.glob('word/document*.xml').first | |||
There was a problem hiding this comment.
I don't know the specification of Office Open XML file format.
Is there no docx file which have some xml files with prefix 'word/document'?
The PR #73 tries to deal with all the xml.
There was a problem hiding this comment.
The specifications can be found here: http://officeopenxml.com/anatomyofOOXML.php
If we want to be more clean, we should load [Content_Types].xml and check the name of the document.
I will work on a new PR that will use [Content_Types].xml to define all XML.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103