-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review k*-p* feature files for dnf5 #1584
Merged
Merged
Commits on Oct 31, 2024
-
The note was made to explain why the feature is disabled and it wasn't removed when it was enabled later on.
Configuration menu - View commit details
-
Copy full SHA for 0c9b3ea - Browse repository at this point
Copy the full SHA 0c9b3eaView commit details
Commits on Nov 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8cae0b5 - Browse repository at this point
Copy the full SHA 8cae0b5View commit details -
Since there are no longer other logs than the dnf5.log, some scenarios or parts of tests that tested these logs are removed.
Configuration menu - View commit details
-
Copy full SHA for 88255e3 - Browse repository at this point
Copy the full SHA 88255e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c23d2e - Browse repository at this point
Copy the full SHA 5c23d2eView commit details -
Adjust metadata.feature test output for dnf5
Dnf5 doesn't print the whole messages from librepo on stdout, it instead prints them on stderr, plus they are truncated, possibly because there can be many errors from librepo at once, for example due to trying many mirrors. The full message is then in the dnf5.log.
Configuration menu - View commit details
-
Copy full SHA for 4e6d656 - Browse repository at this point
Copy the full SHA 4e6d656View commit details -
Configuration menu - View commit details
-
Copy full SHA for b9a4d1b - Browse repository at this point
Copy the full SHA b9a4d1bView commit details -
Fix obsoletes scenario to test the desired behavior
There is no point in testing that the behavior is incorrect and having just a note about the correct one.
Configuration menu - View commit details
-
Copy full SHA for a518990 - Browse repository at this point
Copy the full SHA a518990View commit details -
There is no reason to test that dnf stores internal information in a specific place.
Configuration menu - View commit details
-
Copy full SHA for 4bc9d35 - Browse repository at this point
Copy the full SHA 4bc9d35View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ee47d2 - Browse repository at this point
Copy the full SHA 6ee47d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for c374112 - Browse repository at this point
Copy the full SHA c374112View commit details -
Configuration menu - View commit details
-
Copy full SHA for b3c0059 - Browse repository at this point
Copy the full SHA b3c0059View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.