Review k*-p* feature files for dnf5 #1584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The note was made to explain why the feature is disabled and it wasn't removed when it was enabled later on.
Since there are no longer other logs than the dnf5.log, some scenarios or parts of tests that tested these logs are removed.
Dnf5 doesn't print the whole messages from librepo on stdout, it instead prints them on stderr, plus they are truncated, possibly because there can be many errors from librepo at once, for example due to trying many mirrors. The full message is then in the dnf5.log.
There is no point in testing that the behavior is incorrect and having just a note about the correct one.
There is no reason to test that dnf stores internal information in a specific place.
kontura
approved these changes
Nov 4, 2024
| @@ -82,4 +82,8 @@ Scenario: present user understandable message when there is a mismatch between a | |||
| And I execute "echo \"checksum mismatch\" >> /{context.dnf.repos[simple-base].path}/x86_64/labirinto-1.0-1.fc29.x86_64.rpm" | |||
| When I execute dnf with args "install labirinto" | |||
| Then the exit code is 1 | |||
| And stdout contains "\[MIRROR\] labirinto-1.0-1.fc29.x86_64.rpm: Interrupted by header callback: Inconsistent server data, reported file Content-Length: .*, repository metadata states file length: .* \(please report to repository maintainer\)" | |||
| And stderr contains "Interrupted by header callback: Inconsistent server data" | |||
There was a problem hiding this comment.
I personally don't like the truncating and I have filed an issue for it: rpm-software-management/dnf5#1829
We can keep the test like this and depending on what is decided in the issue it can be updated later (or not).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far except for plugin* feature files, since these will probably need bigger changes.