Allow topic remapping in output YAML format for ros2 bag convert
#1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Orlov <[email protected]>
Signed-off-by: Andrew Symington <[email protected]>
asymingt
force-pushed
the
asymingt/topics_remaping_in_bag_rewriter
branch
from
be35dec
to
9094cbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1026. I have the README changes, YAML parsing and remapping code implemented, but I think I have a problem with local versus global namespacing of topics in a bag, which is surfaced by the two unit tests I added. I suspect that I'm not calling
rcl_remap_topic_nameproperly.