Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated spin_until_future_complete #2

Closed
wants to merge 1 commit into from
Closed

Replace deprecated spin_until_future_complete #2

wants to merge 1 commit into from

Conversation

hliberacki
Copy link

@hliberacki hliberacki commented Mar 31, 2022 •
edited by christophebedard
Loading

Replace deprecated spin_until_future_complete with spin_until_complete

Signed-off-by: Hubert Liberacki [email protected]

action-ros-ci-repos-override: https://gist.githubusercontent.com/christophebedard/11821dfe3c6bc30740424e3f1aadc00a/raw/c89766f8e94f902dc1845a774eb0073f7eabcf10/ros2.repos

@hliberacki
Copy link
Author

Due to change in RCLCPP - ros2/rclcpp#1874 Pull request

@christophebedard
Copy link
Member

Thanks for the PR @hliberacki! Since this GitHub repo is just a mirror, do you mind moving this to the GitLab repo? https://gitlab.com/ros-tracing/ros2_tracing

If not, I can do it!

@hliberacki
Copy link
Author

@christophebedard I wasn't aware of that :) good to know. Yes, I can move it to GitLab no problem - yet I will be able to do it later today (in 3-4 hours from now, since I am off my PC at the moment). If you'd like to have it quicker and be kind enough to do it for me, it would be great as well :)

@christophebedard
Copy link
Member

I opened a merge request with your commit here: https://gitlab.com/ros-tracing/ros2_tracing/-/merge_requests/291.

I'll close this PR now.

@christophebedard
Copy link
Member

Re-opening this since the repo was moved to GitHub.

@christophebedard christophebedard force-pushed the hliberacki/spin_until branch 2 times, most recently from f145774 to ef43eb4 Compare November 23, 2022 01:04
@christophebedard
Copy link
Member

Test failures are due to #27

@christophebedard christophebedard changed the title Update depracated spin_until_future_complete Update deprecated spin_until_future_complete Nov 26, 2022
@christophebedard christophebedard mentioned this pull request Nov 30, 2022
Closed
@clalancette clalancette added the backlog No plans to be worked on for now label Dec 15, 2022
@fujitatomoya fujitatomoya mentioned this pull request Jan 23, 2023
Open
@christophebedard christophebedard changed the base branch from master to rolling January 23, 2023 18:39
@christophebedard
Copy link
Member

I re-targeted the PR from master to rolling (since rolling is the default branch now) and rebased the branch on rolling.

ymski pushed a commit to ymski/ros2_tracing that referenced this pull request May 22, 2023
@takam5f2
chore: enlarge buffer size for avoiding tracer discarded (ros2#2)
43df7ae 
Signed-off-by: Takayuki AKAMINE <[email protected]>

Signed-off-by: Takayuki AKAMINE <[email protected]>
clalancette added a commit that referenced this pull request Mar 26, 2024
@clalancette
Use a memcmp for the expected symbol name.
32aff54 
I believe that g++ does not guarantee what a particular
symbol name will be.  Thus, in g++ 11.4.0 (what is in
Ubuntu 22.04), the symbol name here ended with "#2", while
in g++ 13.2.0 (what is in Ubuntu 24.04), the symbol name
ends with "#1".  Given that we can't guarantee this, just
search for the first part of the name up to the number,
which should be good enough for this test.

Signed-off-by: Chris Lalancette <[email protected]>
@clalancette clalancette mentioned this pull request Mar 26, 2024
Merged
clalancette added a commit that referenced this pull request Mar 26, 2024
@clalancette
Use a memcmp for the expected symbol name. (#100)
0d720e1 
* Use a memcmp for the expected symbol name.

I believe that g++ does not guarantee what a particular
symbol name will be.  Thus, in g++ 11.4.0 (what is in
Ubuntu 22.04), the symbol name here ended with "#2", while
in g++ 13.2.0 (what is in Ubuntu 24.04), the symbol name
ends with "#1".  Given that we can't guarantee this, just
search for the first part of the name up to the number,
which should be good enough for this test.

Signed-off-by: Chris Lalancette <[email protected]>
@christophebedard christophebedard removed the backlog No plans to be worked on for now label Apr 2, 2024
@christophebedard christophebedard mentioned this pull request Apr 2, 2024
Open
@christophebedard christophebedard changed the title Update deprecated spin_until_future_complete Update deprecated spin_until_future_complete Apr 2, 2024
@christophebedard christophebedard changed the title Update deprecated spin_until_future_complete Replace deprecated spin_until_future_complete Apr 2, 2024
@christophebedard
Copy link
Member

As per the discussion in ros2/rclcpp#2475 (comment), we will not be doing this. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hliberacki @christophebedard @fujitatomoya @clalancette