Extend ROS resource addressing design document #241
Conversation
Signed-off-by: Michel Hidalgo <[email protected]>
|
As a follow-up, the design document on static name remapping will need an update as well. |
hidmic
changed the title
hidmic
changed the title
| - must not start with a numeric character (`[0-9]`). | ||
| - must not end nor start with a period (`.`). | ||
| - must not contain any number of repeated periods (`.`). | ||
| - must not contain any number of repeated underscores (`_`). |
There was a problem hiding this comment.
So this is back :D. We should figure out what we're doing here and be consistent. Unless I missed it this wasn't a constraint mentioned above. I think we may have wanted to keep it to allow us to have a "safe" delimiter to use in the future, but it looks like the code doesn't check this, at least for topics.
There was a problem hiding this comment.
Made this constraint explicit everywhere else in 7680627. Do you think we shouldn't?
There was a problem hiding this comment.
Hmm, not sure. I think we only needed it for the alternative we're no longer using. I don't think the code enforces it at the moment. Maybe it should be removed. @sloretz or anyone on the @ros2/team do you have an opinion here?
There was a problem hiding this comment.
I don't have a strong preference. But it seems okay to remove the constraint if there's no reason to have it. If we really need it in the future, we could start using repeated . as a delimiter since it's already disallowed.
- Enable redirects to avoid breaking existing permalinks - Improve overall writing and internal consistency - Added additional citations Signed-off-by: Michel Hidalgo <[email protected]>
| - must not start with a numeric character (`[0-9]`). | ||
| - must not end nor start with a period (`.`). | ||
| - must not contain any number of repeated periods (`.`). | ||
| - must not contain any number of repeated underscores (`_`). |
There was a problem hiding this comment.
I don't have a strong preference. But it seems okay to remove the constraint if there's no reason to have it. If we really need it in the future, we could start using repeated . as a delimiter since it's already disallowed.
Signed-off-by: Michel Hidalgo <[email protected]>
|
@hidmic What is the status on this? Can it be merged or does it need to move forward to the Foxy board? |
|
It has yet to be implemented, so if anything it has to go to the Foxy board. It was brought up during our brainstorming for Foxy, but AFAIK it has a rather low priority. |
|
ros2/ros2#881 to track progress on this topic. |
This pull request generalizes the existing topic and service name addressing design document to cover the current goals in terms of addressing topics, services, actions and parameters in ROS 2.