Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter grouping doesn't work with new command line syntax #528

Closed
ivanpauno opened this issue Oct 23, 2019 · 5 comments
Closed

Parameter grouping doesn't work with new command line syntax #528

ivanpauno opened this issue Oct 23, 2019 · 5 comments
Labels
bug Something isn't working

Comments

@ivanpauno
Copy link
Member

Bug report

Required Info:

  • Operating System:
    • Ubuntu 18.04
  • Installation type:
    • from source
  • Version or commit hash:
    • master
  • DDS implementation:
    • Any
  • Client library (if applicable):
    • rclcpp (probably the same happens in rclpy)

Steps to reproduce issue

ros2 run demo_nodes_cpp parameter_blackboard --ros-args -p "some_lists.some_integers:=[1, 2, 3, 4]"

Expected behavior

The node is created with the specified parameters.

Actual behavior

An error:

[ERROR] [rcl]: Failed to parse global arguments

Additional information

Connected with ros2/ros2_documentation#376.

@ivanpauno ivanpauno added the bug Something isn't working label Oct 23, 2019
@ivanpauno
Copy link
Member Author

@hidmic FYI

@hidmic
Copy link
Contributor

hidmic commented Oct 23, 2019

As we spoke offline, this is due to an inconsistency in how the YAML parser in rcl_yaml_param_parser names parameters and how rcl expects to parse them: the former uses dots (.) to flatten dictionaries, the latter expects slashes (/). IIUC we want to go towards slashes, there's even a design document about it. But it's likely too late to make it uniform everywhere.

So, I'll change rcl to use dots now and I'll leave a TODO to go back to slashes for F-Turtle. @dirk-thomas @mjcarroll @wjwwood for awareness.

@jacobperron
Copy link
Member

@hidmic Can this be closed since #530 ?

@mjcarroll
Copy link
Member

@hidmic another bump, can this one be closed now?

@hidmic
Copy link
Contributor

hidmic commented Nov 14, 2019

Whoops, completely lost the notification. Yes, we can close.

@hidmic hidmic closed this as completed Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants