-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates PickNik team membership #281
Conversation
This fixes ros2-gbp#280 Signed-off-by: Alex Moriarty <[email protected]>
FYI @MarqRazz |
@mjcarroll you approved but it's still waiting for a approval from a maintainer, I don't see a .github/CODEOWNERS file or equivalent to know who should be assigned to this issue. Is it only OSRC or the whatever the new team within Intrinsic who are able to approve and merge these PRs? Maybe adding something like this: https://probot.github.io/apps/auto-assign/ would be a good way of randomly assigning reviewers from a pool of eligible reviewers? |
This one is up to @nuclearsandwich, I believe. I don't have write privileges in here, but I approved it as part of my rotation on rosdistro this week. |
This organization is maintained by OSRF, specifically the Infrastructure Project Committee for which I'm the appointed maintainer of this project although not the only one with capability to deploy in the event I'm inaccessible. I usually try to sweep through at least twice a week and we're working some tooling that will make deployment, and thus maintainership, for this project easier to share across the team. |
* Add picknik_controllers The purpose of picknik_controllers repository is hold controllers that we are in the process of open sourcing and upstreaming. The controllers in this repository have been prefixed with `picknik_` so that if they are accepted upstream we will drop the prefix and release the prefixed versions with deprication warnings. - picknik_reset_fault_controller has been discussed here https://roscontrol.slack.com/archives/C01HA09KDLH/p1686332900429009 - picknik_twist_controller ros-controls/ros2_controllers#300 These do not have a gbp-release package and have not been release they are currently source only. Following the steps outlined here: https://docs.ros.org/en/rolling/How-To-Guides/Releasing/First-Time-Release.html This PR is for step 2 1. Be part of a release team: ros2-gbp/ros2-gbp-github-org#281 2. https://docs.ros.org/en/rolling/How-To-Guides/Releasing/Release-Team-Repository.html#create-a-new-release-repository Signed-off-by: Alex Moriarty <[email protected]> * fixup: remove the release Signed-off-by: Alex Moriarty <[email protected]> * fixup repo typo - PickNikRobots -> PickNikRobotics Signed-off-by: Alex Moriarty <[email protected]> --------- Signed-off-by: Alex Moriarty <[email protected]>
This fixes #280