Adding people perception and other things #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@suryaambrose what do you think? there are many useful features! |
|
@cdondrup you may want to rebase for resolving merge conflicts. |
|
@nlyubova I'd rather not merging this, at least for now. naoqi_driver was supposed to be about very "low" robotics stuff (very sensor-oriented). Battery status is fine for that matter, and sound source localisation can also be good, but I am less keen on letting people perception and behavior manager features in. A while ago, @kochigami also proposed to bind PeoplePerception and FaceDetection API and we refused (and she finally binded those API in naoqi_apps, which is more suited for that I think, even though it is in Python). However, if the willingness to bind those API here is strong, this "sensor-only" orientation can of course be challenged. |
…seArray Also adding the possibility of publishing mutliple faces
…cking are supported.
Adding more functionality from ALLocalization Introducing sub-namespaces for all new services to make the easier to distinguish
…ve a blocking call.
…t allows to make blocking calls in addition to the fire and forget topic that already exists. Also adding basic robot posture control.
Adding additional ALLocalization, ALTracker, and ALMotion services This PR adds more functionality in terms of services. **Major change to interface:** The services are now prefixed with a subnamespace to be able to distinguish them better. E.g. `/naoqi_driver/start_behaviour` is now `/naoqi_driver/behavior_manager/start_behaviour`, etc. While this is a major change that requires altering modules using these services, I believe that it is necessary given the amount of services provided by the driver. Also, I don't think that anyone but me is currently using these functionalities. **Added functionality:** * ALLocalization: * Loading, saving, and clearing of localisation data * Checking if localisation data is loaded * Stopping everything (to be able to preempt the action of going home) * Looking up error messages based on their error code * ALTracker * `lookAt` and `pointAt` functionality * ALMotion * En-/Dis-abling breathing animation * Speech synthesis * While `ALTextToSpeech.say` and `ALAnimatedSpeech.say` are already implemented as subscribers, I also implemented them as services which provide the unique benefit of being a blocking call. This is essential for the dialogue because we need to know when the robot has finished its utterance. You can still use both. This requires: http://protolab.aldebaran.com:9000/mummer/nao_interaction/merge_requests/4 See merge request !6
cdondrup
force-pushed
the
add_facedetected
branch
from
7a9e358
to
c6fa3e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I am part of the MuMMER project and we recently started using the pepper robot and required some functionalities that weren't implemented in the current version of the driver.
This PR is based on #56 and includes #65 as well.
Here a list of the added functionality:
Additionally, it also contains a few commits of @nlyubova regarding distortion and colour spaces. All this currently relies on the
nao_interaction_msgspackage which can be found in my fork: https://github.com/cdondrup/nao_interaction (didn't want to open a PR for that because I don't think this has a chance of being merged as it currently is ;) )This PR is not really meant to be merged directly as it might introduce too many untested changes but should mainly serve to show what we are currently working on in case people are interested. I am more than happy about comments and if there is any interest I am of course happy to restructure for a possible merge so we can keep a cleaner commit history.
All this has been tested by @nlyubova and myself on pepper but not on NAO.