Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Jazzy to REP 2000 #387

Merged

Conversation

marcoag
Copy link

@marcoag marcoag commented Nov 10, 2023

This PR adds an entry for Jazzy Jalisco to REP 2000.

Things to note:

  • Added zenoh
  • Only updated versions for ubuntu and debian packages
  • Ubuntu Noble versions are whatever currently shows up at: https://packages.ubuntu.com
  • Package manager for dependencies was showing apt for Debian and Ubuntu but afaik rosdep also uses pip in these systems. I added it but let me know if I should remove it.

Signed-off-by: Marco A. Gutierrez <[email protected]>
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks like a good start, thanks.

I've left a few things inline to fix.

rep-2000.rst Outdated Show resolved Hide resolved
rep-2000.rst Outdated Show resolved Hide resolved
rep-2000.rst Outdated Show resolved Hide resolved
rep-2000.rst Outdated Show resolved Hide resolved
rep-2000.rst Outdated Show resolved Hide resolved
rep-2000.rst Outdated
Comment on lines 1136 to 1138
| Gazebo-classic | 11.x.x* | N/A | N/A | 11.x.x | 11.x.x* | N/A |
+----------------+----------------+----------------+----------+---------------+------------------+---------------------+
| Gazebo | Harmonic* | N/A | N/A | Harmonic* | Harmonic* | N/A |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azeey Can you comment on which versions of Gazebo-classic and Gazebo will be supported/recommended with Ubuntu 24.04?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plan was to drop Gazebo-classic and pair Jazzy with Gazebo Harmonic.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! In that case, @marcoag let's just drop the Gazebo-classic row, and then we can merge this in.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped Gazebo-classic row.

rep-2000.rst Outdated Show resolved Hide resolved
rep-2000.rst Outdated Show resolved Hide resolved
Marco A. Gutierrez and others added 7 commits November 12, 2023 13:30
Co-authored-by: Chris Lalancette <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me for now, thanks. I'll wait to see what @azeey has to say about Gazebo versions before merging.

Signed-off-by: Marco A. Gutierrez <[email protected]>
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for getting this started. We'll update this further as we get more details about Ubuntu 24.04. I'll merge this for now.

@clalancette clalancette merged commit 095f04c into ros-infrastructure:master Nov 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants