-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Jazzy to REP 2000 #387
Adding Jazzy to REP 2000 #387
Conversation
Signed-off-by: Marco A. Gutierrez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks like a good start, thanks.
I've left a few things inline to fix.
rep-2000.rst
Outdated
| Gazebo-classic | 11.x.x* | N/A | N/A | 11.x.x | 11.x.x* | N/A | | ||
+----------------+----------------+----------------+----------+---------------+------------------+---------------------+ | ||
| Gazebo | Harmonic* | N/A | N/A | Harmonic* | Harmonic* | N/A | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@azeey Can you comment on which versions of Gazebo-classic and Gazebo will be supported/recommended with Ubuntu 24.04?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plan was to drop Gazebo-classic and pair Jazzy with Gazebo Harmonic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! In that case, @marcoag let's just drop the Gazebo-classic
row, and then we can merge this in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropped Gazebo-classic
row.
Co-authored-by: Chris Lalancette <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me for now, thanks. I'll wait to see what @azeey has to say about Gazebo versions before merging.
Signed-off-by: Marco A. Gutierrez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks for getting this started. We'll update this further as we get more details about Ubuntu 24.04. I'll merge this for now.
This PR adds an entry for Jazzy Jalisco to REP 2000.
Things to note:
apt
for Debian and Ubuntu but afaik rosdep also uses pip in these systems. I added it but let me know if I should remove it.