Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desugar patterns #6099

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Desugar patterns #6099

merged 4 commits into from
Nov 27, 2023

Commits on Nov 27, 2023

  1. replace unreachable! with internal_error! in expr canonicalization 

    See roc-lang#2046
    @mulias
    mulias committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    0a48962 View commit details
    Browse the repository at this point in the history

  2. desugar patterns during canonicalization 

    Traverse pattern ASTs and desugar two cases

- Desugar optional record field default value expr. This expr might
  contain nodes that need to be desugared, such as binary operations.
  Failing to desugar this expr can cause an internal panic later in
  canonicalization.

- Discard SpaceBefore and SpaceAfter nodes so that patterns can be
  destructured over multiple lines. Keeping these nodes can cause an
  internal panic later in canonicalization. Fixes [1].

[1]: roc-lang#5653.
    @mulias
    mulias committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    439ce11 View commit details
    Browse the repository at this point in the history

  3. remove unnecessary comment

    @mulias
    mulias committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    d924125 View commit details
    Browse the repository at this point in the history

  4. move pattern desugar tests to test_mono

    @mulias
    mulias committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    0ccc713 View commit details
    Browse the repository at this point in the history