Desugar patterns #6099
Merged
Desugar patterns #6099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mulias
force-pushed
the
desugar-patterns
branch
2 times, most recently
from
05c07e3
to
5854420
Compare
ayazhafiz
previously approved these changes
Nov 26, 2023
crates/compiler/can/src/operator.rs
Outdated
Comment on lines
575
to
576
| // Find `OptionalField`s and desugar the default value exprs. Also discard `SpaceBefore` and | ||
| // `SpaceAfter` nodes so that patterns can be destructured over multiple lines. |
There was a problem hiding this comment.
Slight preference for removing this comment. I think it's pretty clear what the function does from the body, and it's pretty likely it will grow out of date if the logic is ever updated.
There was a problem hiding this comment.
Makes sense, removed
| @@ -1231,6 +1231,54 @@ mod test_can { | |||
| assert_eq!(problems, Vec::new()); | |||
| } | |||
|
|
|||
| #[test] | |||
There was a problem hiding this comment.
You might consider asserting on the can AST (you could print it back using
) or adding tests in test_mono to assert the code generation is as expectedThere was a problem hiding this comment.
I moved the tests to test_mono because that seemed simpler.
Traverse pattern ASTs and desugar two cases - Desugar optional record field default value expr. This expr might contain nodes that need to be desugared, such as binary operations. Failing to desugar this expr can cause an internal panic later in canonicalization. - Discard SpaceBefore and SpaceAfter nodes so that patterns can be destructured over multiple lines. Keeping these nodes can cause an internal panic later in canonicalization. Fixes [1]. [1]: roc-lang#5653.
mulias
force-pushed
the
desugar-patterns
branch
from
5854420
to
0ccc713
Compare
ayazhafiz
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Traverse pattern ASTs and desugar two cases
Desugar optional record field default value expr. This expr might contain nodes that need to be desugared, such as binary operations. Failing to desugar this expr can cause an internal panic later in canonicalization.
Discard SpaceBefore and SpaceAfter nodes so that patterns can be destructured over multiple lines. Keeping these nodes can cause an internal panic later in canonicalization. Fixes Problem compiling Tutorial example: Optional Record Fields #5653.