-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web REPL cleanups #5863
Web REPL cleanups #5863
Conversation
I think we should be able to do this using the same way we do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely, thanks @brian-carroll! 🎉
@@ -32,7 +31,7 @@ const repl = { | |||
app: null, | |||
|
|||
// Temporary storage for values passing back and forth between JS and Wasm | |||
result: { addr: 0, buffer: new ArrayBuffer() }, | |||
result_addr: { addr: 0, buffer: new ArrayBuffer() }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wow, this is wrong. This field was changed to a number everywhere else.
The initial value always get overwritten, so everything works. But it's confusing.
I'll make another PR.
dbg
we might need to bring back WASI? There are other ways of implementing it.Previous loading state
Darker than normal because I paused JS at a breakpoint to take the screenshot
New loading state
Darker than normal because I paused JS at a breakpoint to take the screenshot
Loaded state