Fix a confusing initial value in the web REPL JS #5873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5863 I make
result_addra number, whereas it used to be an object.I forgot to change the initial value though! It's still an object!
The initial value is always overwritten, so it has no effect on functionality. But the whole point of that PR was code clarity, so let's fix it!
The default git diff isn't really enough to see that this is correct. You might want to "view file" and see the other 2 usages of the field, which treat it as a number.
This fix is not urgent because everything works. But people might look at the source code after I do a talk on it tomorrow and get confused.