Add file percentage in visual mode (V/Vv)

[PeiweiHu]

PLEASE DON'T SQUASH

two commits are individual

Your checklist for this pull request

• I've read the guidelines for contributing to this repository
• I made sure to follow the project's coding style
• I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
• I've added tests that prove my fix is effective or that my feature works (if possible)
• I've updated the rizin book with the relevant information (if needed)

Detailed description

calculation logics

For Vv, the percentage is calculated based on the lines of output in the right column:

current_line_no / total_line_num

For V, the percentage is calculated based on the percentage of the current address against the mapped section memory:

(address - section_start_addr) / section_size

This pr adds a static global variable:

static ut64 column_nlines = 0;

No worries. I will remove it with other related global variables in subsequent pr.

static int level = 0;
static st64 delta = 0;
static ut64 column_nlines = 0;
// output is used to store the result of printCmds
// and avoid duplicated analysis while j and k is pressed
static char *output = NULL;
// output_mode labels which printCmds' result is stored in output
static int output_mode = -1;
static int output_addr = -1;
static int option = 0;
static int variable_option = 0;
static int printMode = 0;
static bool selectPanel = false;

Test plan

manual test since we don't have a mechanism for testing tui

Closing issues

closes #4477

Screen.Recording.2024-05-16.at.15.43.32.mov

[wargio]

it would be nice to at least have one big struct and just one global.

[wargio]

For those like me not seeing it, percentage is on the lower corner in v mode and upper corner in V mode.

[wargio]

.

[XVilka]

I see where the global added. While they should be eliminated, if you really plan to remove them in bulk from vmenus.c - I suppose it's okay for now.

[XVilka]

Please rebase to fix the red CI

[PeiweiHu]

For those like me not seeing it, percentage is on the lower corner in v mode and upper corner in V mode.

Sorry, I don't get it. I think I didn't add percentage in v mode (visual panel mode). Do you mean that the positions of percentage are different in Vv and V modes?

[wargio]

For those like me not seeing it, percentage is on the lower corner in v mode and upper corner in V mode.

Sorry, I don't get it. I think I didn't add percentage in v mode (visual panel mode). Do you mean that the positions of percentage are different in Vv and V modes?

kinda. i actually never seen the perc value thus that is why i was actively searching for it :D ignore my comment :)

[wargio]

<3

[XVilka]

@PeiweiHu it doesn't work in the simple visual mode. Simply do rizin /bin/ls, then V and scroll. You can try different modes with p/P and scroll - it also always stays at 0%.

[XVilka]

@PeiweiHu it doesn't work in the simple visual mode. Simply do rizin /bin/ls, then V and scroll. You can try different modes with p/P and scroll - it also always stays at 0%.

What's interesting, that it works in the "last" of the visual modes (the "hexII" mode, the "sparse hexdump", press V then p multiple times), while doesn't in any other mode.