Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual mode percentage doesn't work #4518

Closed
XVilka opened this issue May 26, 2024 · 4 comments · Fixed by #4536
Closed

Visual mode percentage doesn't work #4518

XVilka opened this issue May 26, 2024 · 4 comments · Fixed by #4536
Labels
Milestone

Comments

@XVilka
Copy link
Member

XVilka commented May 26, 2024

@PeiweiHu it doesn't work in the simple visual mode. Simply do rizin /bin/ls, then V and scroll. You can try different modes with p/P and scroll - it also always stays at 0%.

What's interesting, that it works in the "last" of the visual modes (the "hexII" mode, the "sparse hexdump", press V then p multiple times), while doesn't in any other mode.

Originally posted by @XVilka in #4494 (comment)

@XVilka XVilka added this to the 0.8.0 milestone May 26, 2024
@XVilka XVilka added the visual label May 26, 2024
@PeiweiHu
Copy link
Contributor

PeiweiHu commented Jun 5, 2024

Will try to address it once I'm free.

PS: please also feel free to take it for anyone that is interested in it.

@PeiweiHu
Copy link
Contributor

PeiweiHu commented Jun 5, 2024

Hi, @XVilka

I tried but failed to reproduce the errors. It seems that the percentage works normally on my pc. I post the video in the following. Do I miss any steps to reproduce it?

2024-06-05.222729.mp4

@TheN00bBuilder
Copy link
Contributor

TheN00bBuilder commented Jun 6, 2024

@PeiweiHu I was able to reproduce the original error by doing the same thing you did in your video. Typing the same things you did makes the percentage not update when scrolling. Not sure if it makes a difference but I'm on Ubuntu 20.04.

I can attempt to look at this later this week if you're still having issues reproducing the bug. Can't guarantee anything as I'm still really unfamiliar with the codebase, but maybe I can help pinpoint the issue.

@PeiweiHu
Copy link
Contributor

PeiweiHu commented Jun 6, 2024

@TheN00bBuilder Thank you so much! I can reproduce now without using tmux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants