Revert memory leak fix for relocs

[giridharprasath]

Your checklist for this pull request

• I've read the guidelines for contributing to this repository
• I made sure to follow the project's coding style
• I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
• I've added tests that prove my fix is effective or that my feature works (if possible)
• I've updated the rizin book with the relevant information (if needed)

Detailed description

See: #4426

...

Test plan

...

Closing issues

...

[XVilka]

I wonder why it reverted the test result back?

[pelijah]

I wonder why it reverted the test result back?

IDK about vaddr of the import, might be a bug in PE plugin or in bin lib. But case of a name is a good example of side effects: PE plugin modifies a duplicate which is not presented in imports list.

[pelijah]

@XVilka What worries me more is that asan jobs didn't catch those UAF/double free.

[XVilka]

It probably means we don't have enough testcases for these paths - PE, COFF format parsers.

[pelijah]

It probably means we don't have enough testcases for these paths - PE, COFF format parsers.

No, it is enough to just open/close with rizin any COFF file from testbins to trigger UAF.

[pelijah]

But ASAN is happy if I run rz-test test/db/formats/coff

[pelijah]

Nevermind it is all about Q option