Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test normal quitting with coff bin #4467

Closed
wants to merge 5 commits into from

Conversation

kazarmy
Copy link
Member

@kazarmy kazarmy commented May 2, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

This pr modifies a test so that the asan builds can check whether there are any asan-related problems with coff bins when quitting normally, specifically to address the concern raised here.

Test plan

The asan builds should be red until the [TO BE REVERTED] commits are reverted, in which all builds should be green.

Closing issues

...

kazarmy and others added 2 commits May 2, 2024 19:17
* Fix memory leaks in debug path
* Fix memory leaks in mach and mdmp format
* Update the fix for mach
* Add support for aarch64 tcache parsing
* Test case fix
* Comment update

---------

Co-authored-by: Giridhar Prasath R <[email protected]>
@kazarmy kazarmy marked this pull request as ready for review May 2, 2024 12:43
@pelijah
Copy link
Contributor

pelijah commented May 2, 2024

We need to get rid of quietLeak:

rizin/librz/main/rizin.c

Lines 1538 to 1541 in ba780a7

if (quietLeak) {
exit(ret);
return ret;
}

@kazarmy
Copy link
Member Author

kazarmy commented May 3, 2024

Hmm it should actually be called quickLeak but ok

@kazarmy kazarmy closed this May 3, 2024
@kazarmy kazarmy mentioned this pull request May 3, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants