Rzil PIC

[imbillow]

Your checklist for this pull request

• I've read the guidelines for contributing to this repository
• I made sure to follow the project's coding style
• I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
• I've added tests that prove my fix is effective or that my feature works (if possible)
• I've updated the rizin book with the relevant information (if needed)

Detailed description

ref #3461

https://en.wikipedia.org/wiki/PIC_instruction_listings

https://developerhelp.microchip.com/xwiki/bin/view/products/mcu-mpu/8bit-pic/enhanced-family/emdata/

• Uplift PIC Mid-Range (PIC16)
  • https://ww1.microchip.com/downloads/en/devicedoc/33023a.pdf
  • https://web.archive.org/web/20220418040755/https://www.microchip.com/stellent/groups/SiteComm_sg/documents/DeviceDoc/en542713.pdf
• Uplift PIC Base-Line (PIC14)
• Uplift PIC High-End (PIC18)

Test plan

...

Closing issues

closes #3461

[imbillow]

Looks almost ready. The only thing left is rename, I guess?

This one should be done.

[imbillow]

It seems rizin has some segment mapping issues for pic16 elf files. This causes the emulate test not to run as expected.

[0x00000000]> omlt
.----------------------------------------------------------------------.
| id | fd | pa    | pa_end | size | va    | va_end | perm | name       |
)----------------------------------------------------------------------(
| 1  | 3  | 0x34  | 0x7c   | 0x48 | 0x7db | 0x823  | r--  | fmap.LOAD0 |
| 2  | 3  | 0x7c  | 0xee   | 0x72 | 0x7a2 | 0x814  | r--  | fmap.LOAD1 |
| 3  | 3  | 0xee  | 0xf8   | 0xa  | 0x78c | 0x796  | r--  | fmap.LOAD2 |
| 4  | 4  | 0x0   | 0xa    | 0xa  | 0x70  | 0x7a   | rw-  | mmap.LOAD3 |
| 5  | 3  | 0xf8  | 0x102  | 0xa  | 0x0   | 0xa    | r--  | fmap.LOAD4 |
| 6  | 3  | 0x102 | 0x124  | 0x22 | 0x791 | 0x7b3  | r--  | fmap.LOAD5 |
| 7  | 3  | 0x124 | 0x154  | 0x30 | 0x5   | 0x35   | r--  | fmap.LOAD6 |
| 8  | 5  | 0x0   | 0x11   | 0x11 | 0x20  | 0x31   | rw-  | mmap.LOAD7 |
| 9  | 6  | 0x0   | 0x2    | 0x2  | 0x7e  | 0x80   | rw-  | mmap.LOAD8 |
`----------------------------------------------------------------------'

If you know the problem/fix, it's probably better to send as a separate PR, to merge before this one.

Though but I don't know the fix. It just feels like a pic16 emulateme test could be added with some hacks

[XVilka]

Looks almost ready. The only thing left is rename, I guess?

This one should be done.

Oh, right, I was mistaken because of the old filenames shown in the diff (removed files).

[XVilka]

It seems rizin has some segment mapping issues for pic16 elf files. This causes the emulate test not to run as expected.

[0x00000000]> omlt
.----------------------------------------------------------------------.
| id | fd | pa    | pa_end | size | va    | va_end | perm | name       |
)----------------------------------------------------------------------(
| 1  | 3  | 0x34  | 0x7c   | 0x48 | 0x7db | 0x823  | r--  | fmap.LOAD0 |
| 2  | 3  | 0x7c  | 0xee   | 0x72 | 0x7a2 | 0x814  | r--  | fmap.LOAD1 |
| 3  | 3  | 0xee  | 0xf8   | 0xa  | 0x78c | 0x796  | r--  | fmap.LOAD2 |
| 4  | 4  | 0x0   | 0xa    | 0xa  | 0x70  | 0x7a   | rw-  | mmap.LOAD3 |
| 5  | 3  | 0xf8  | 0x102  | 0xa  | 0x0   | 0xa    | r--  | fmap.LOAD4 |
| 6  | 3  | 0x102 | 0x124  | 0x22 | 0x791 | 0x7b3  | r--  | fmap.LOAD5 |
| 7  | 3  | 0x124 | 0x154  | 0x30 | 0x5   | 0x35   | r--  | fmap.LOAD6 |
| 8  | 5  | 0x0   | 0x11   | 0x11 | 0x20  | 0x31   | rw-  | mmap.LOAD7 |
| 9  | 6  | 0x0   | 0x2    | 0x2  | 0x7e  | 0x80   | rw-  | mmap.LOAD8 |
`----------------------------------------------------------------------'

If you know the problem/fix, it's probably better to send as a separate PR, to merge before this one.

Though but I don't know the fix. It just feels like a pic16 emulateme test could be added with some hacks

Could you please try to look if it's something easy/obvious? If yes, it's better to fix it properly. But if you can't see the problem quickly, then it will be fine to add the emulateme with workarounds.

[XVilka]

LGTM with one small nitpick