Replace current regex engine with PCRE2 #4185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PCRE2 has way better performance than the OpenBSD library (something around 20 times faster). The following flags are enabled for every pattern: - PCRE2_UTF - PCRE2_MATCH_INVALID_UTF - PCRE2_NO_UTF_CHECK All the others are optional. Changes made: - Adds PCRE2 as subproject. - Changes the API away from POSIX to PCRE2. - Edits many regex patterns because: - ' ' is skipped in patterns, if the EXTENDED flag is set for matching. '\s' must be set now. - '.' doesn't match newlines by default. - Changes the API so matches and their groups are bundled into PVectors. - Moves the regex component to rz_util.
Rot127
requested review from
ret2libc,
thestr4ng3r,
XVilka,
wargio and
kazarmy
as code owners
wargio
approved these changes
Feb 4, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Meson currently doesn't support subprojects to be native and non-native at the same time. See: mesonbuild/meson#10947 Unfortunately, sdb depends on rz_util which in turn depends on PCRE2. Excluding PCRE2 from the native build makes linking of rz_util not possible anymore. Adding it, will make Meson complain that the dependencies cannot be mixed. Hence, we compile a copy of PCRE2 for the native build if required.
wargio
reviewed
Feb 5, 2024
wargio
reviewed
Feb 5, 2024
|
Why use static linking here? I'm getting on FreeBSD when building against system pcre2. |
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Replace the current regex engine with PCRE2.
Test plan
All green.
Closing issues
closes #3730
Partially addresses #4055
Todo
rz_vector_pop_ptr()function which doesn't usememcpy()and use it inmatch_all_flat(). Or add arz_vector_concat()function with the same functionality.__asmrz_regex_get_match_name