Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PCRE2 sys build for FreeBSD #4307

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Conversation

Rot127
Copy link
Member

@Rot127 Rot127 commented Feb 28, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Fix #4185 (comment)

Test plan

Locally tested

Closing issues

...

@Rot127 Rot127 changed the title Fix static build for FreeBSD Fix PCRE2 sys build for FreeBSD Feb 28, 2024
@XVilka XVilka added this to the 0.7.1 milestone Feb 29, 2024
@Rot127
Copy link
Member Author

Rot127 commented Feb 29, 2024

@arrowd Added a blind fix with 90c0207

Couldn't test it yet, because my internet connection is pretty slow at the moment and setting up FreeBSD takes quite long.
So if you are faster, feel free to drop a note here.

@arrowd
Copy link
Contributor

arrowd commented Feb 29, 2024

Yep, I made the same change locally to fix the build. Thanks!

@XVilka
Copy link
Member

XVilka commented Feb 29, 2024

Please open a new PR from the rizinorg account, and with dist- branch to trigger everything.

@Rot127 Rot127 closed this Mar 1, 2024
@Rot127 Rot127 deleted the pcre2-static-freebsd branch March 1, 2024 04:29
@Rot127 Rot127 restored the pcre2-static-freebsd branch March 1, 2024 05:48
@Rot127 Rot127 reopened this Mar 1, 2024
@Rot127
Copy link
Member Author

Rot127 commented Mar 1, 2024

Dist-fuzz build was green in #4310
Only using this for auto-merge

@Rot127 Rot127 marked this pull request as ready for review March 1, 2024 05:49
@Rot127 Rot127 enabled auto-merge (rebase) March 1, 2024 05:49
@Rot127 Rot127 merged commit c2b9208 into rizinorg:dev Mar 1, 2024
33 of 35 checks passed
@Rot127 Rot127 deleted the pcre2-static-freebsd branch March 1, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants