Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdb_fmt() to setf_asm() in /arch/pic|/riscv|/z80 #4130

Merged
merged 8 commits into from
Jan 22, 2024

Conversation

HN026
Copy link
Contributor

@HN026 HN026 commented Jan 19, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

...

Test plan

...

Closing issues

Partially addresses #1168
...

@HN026 HN026 requested a review from wargio as a code owner January 19, 2024 19:32
@HN026 HN026 changed the title sdb_fmt() to setf_asm() in /arch/pic|/riscv|z80 sdb_fmt() to setf_asm() in /arch/pic|/riscv|/z80 Jan 19, 2024
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nitpick, apart from that - LGTM.

librz/asm/arch/pic/pic_pic18.c Outdated Show resolved Hide resolved
librz/asm/arch/riscv/riscv.c Outdated Show resolved Hide resolved
Copy link
Member

@wargio wargio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert the formatting changes on z80.c and riscv.c
Those files are from GPL sources and should keep the same formatting.

@XVilka
Copy link
Member

XVilka commented Jan 20, 2024

@wargio are you sure about z80.c? It seems LGPL one and uses sdb_fmt heavily. I think it should not be excluded from formatting checks

@wargio
Copy link
Member

wargio commented Jan 21, 2024

@wargio are you sure about z80.c? It seems LGPL one and uses sdb_fmt heavily. I think it should not be excluded from formatting checks

From sys/clang-format.py

skiplist = [
    "/gnu/",
    "librz/asm/arch/vax/",
    "librz/asm/arch/riscv/",
    "librz/asm/arch/sh/gnu/",
    "librz/asm/arch/i8080/",
    "librz/asm/arch/z80/",

@XVilka
Copy link
Member

XVilka commented Jan 21, 2024

@HN026, please proceed with changes in z80 and remove that directory from sys/clang-format.py skiplist.

@XVilka XVilka added this to the 0.7.0 milestone Jan 21, 2024
@XVilka XVilka added high-priority rz-asm refactor Refactoring requests labels Jan 21, 2024
sys/clang-format.py Outdated Show resolved Hide resolved
sys/clang-format.py Outdated Show resolved Hide resolved
librz/asm/arch/z80/z80.c Outdated Show resolved Hide resolved
librz/asm/arch/z80/z80.c Outdated Show resolved Hide resolved
librz/asm/arch/z80/z80.c Outdated Show resolved Hide resolved
librz/asm/arch/z80/z80.c Outdated Show resolved Hide resolved
librz/asm/arch/z80/z80.c Outdated Show resolved Hide resolved
@XVilka XVilka merged commit caca079 into rizinorg:dev Jan 22, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants