-
-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sdb_fmt() to setf_asm() in /arch/pic|/riscv|/z80 #4130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor nitpick, apart from that - LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revert the formatting changes on z80.c
and riscv.c
Those files are from GPL sources and should keep the same formatting.
@wargio are you sure about |
From skiplist = [
"/gnu/",
"librz/asm/arch/vax/",
"librz/asm/arch/riscv/",
"librz/asm/arch/sh/gnu/",
"librz/asm/arch/i8080/",
"librz/asm/arch/z80/", |
@HN026, please proceed with changes in |
Your checklist for this pull request
Detailed description
...
Test plan
...
Closing issues
Partially addresses #1168
...