Skip to content

Commit

Permalink
Turn iOS golden testing back on
Browse files Browse the repository at this point in the history
Restore the .riv files for golden testing. Since they are no longer LFS,
they shouldn't cause problems with the downstream merge.

Add a CI workflow to build golden_test_app and ensure it doesn't
bit-rot.

Diffs=
a22d3ea8c Turn iOS golden testing back on (#7518)

Co-authored-by: Chris Dalton <[email protected]>
  • Loading branch information
csmartdalton and csmartdalton committed Jul 4, 2024
1 parent b1e5a9e commit 701a1df
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .rive_head
Original file line number Diff line number Diff line change
@@ -1 +1 @@
07cbce5511e451396513f9d092a72193d41844f5
a22d3ea8c780dbaed55b55bc340f25104b7aa134
12 changes: 12 additions & 0 deletions golden_test_app/golden_test_app.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
3E3DB3552BF5449D000EAA9E /* Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 3E3DB3542BF5449D000EAA9E /* Assets.xcassets */; };
3E3DB3592BF5449D000EAA9E /* Preview Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 3E3DB3582BF5449D000EAA9E /* Preview Assets.xcassets */; };
3E409FE52BF6B481002DD778 /* RiveRendererTestViews.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3E409FE42BF6B481002DD778 /* RiveRendererTestViews.swift */; };
3E82044C2C13969D00D9BEA1 /* dwarf.riv in Resources */ = {isa = PBXBuildFile; fileRef = 3E8204482C13969D00D9BEA1 /* dwarf.riv */; };
3E82044D2C13969D00D9BEA1 /* text.riv in Resources */ = {isa = PBXBuildFile; fileRef = 3E8204492C13969D00D9BEA1 /* text.riv */; };
3E82044E2C13969D00D9BEA1 /* vector.riv in Resources */ = {isa = PBXBuildFile; fileRef = 3E82044A2C13969D00D9BEA1 /* vector.riv */; };
3E8204502C13F37400D9BEA1 /* AppDelegate.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3E82044F2C13F37400D9BEA1 /* AppDelegate.swift */; };
3E8204522C13F38200D9BEA1 /* SceneDelegate.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3E8204512C13F38200D9BEA1 /* SceneDelegate.swift */; };
3EF6A8C32BF6911300CAC54A /* RiveRuntime.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 3EF6A8C22BF6911300CAC54A /* RiveRuntime.framework */; };
Expand Down Expand Up @@ -41,6 +44,9 @@
3E3DB3582BF5449D000EAA9E /* Preview Assets.xcassets */ = {isa = PBXFileReference; lastKnownFileType = folder.assetcatalog; path = "Preview Assets.xcassets"; sourceTree = "<group>"; };
3E409FE42BF6B481002DD778 /* RiveRendererTestViews.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = RiveRendererTestViews.swift; sourceTree = "<group>"; };
3E7419B02C01ADA9000EA71B /* golden-test-app-Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist; path = "golden-test-app-Info.plist"; sourceTree = SOURCE_ROOT; };
3E8204482C13969D00D9BEA1 /* dwarf.riv */ = {isa = PBXFileReference; lastKnownFileType = file; path = dwarf.riv; sourceTree = "<group>"; };
3E8204492C13969D00D9BEA1 /* text.riv */ = {isa = PBXFileReference; lastKnownFileType = file; path = text.riv; sourceTree = "<group>"; };
3E82044A2C13969D00D9BEA1 /* vector.riv */ = {isa = PBXFileReference; lastKnownFileType = file; path = vector.riv; sourceTree = "<group>"; };
3E82044F2C13F37400D9BEA1 /* AppDelegate.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AppDelegate.swift; sourceTree = "<group>"; };
3E8204512C13F38200D9BEA1 /* SceneDelegate.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SceneDelegate.swift; sourceTree = "<group>"; };
3EF6A8C22BF6911300CAC54A /* RiveRuntime.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; path = RiveRuntime.framework; sourceTree = BUILT_PRODUCTS_DIR; };
Expand Down Expand Up @@ -103,6 +109,9 @@
3E82044B2C13969D00D9BEA1 /* raws */ = {
isa = PBXGroup;
children = (
3E8204482C13969D00D9BEA1 /* dwarf.riv */,
3E8204492C13969D00D9BEA1 /* text.riv */,
3E82044A2C13969D00D9BEA1 /* vector.riv */,
);
path = raws;
sourceTree = "<group>";
Expand Down Expand Up @@ -174,8 +183,11 @@
isa = PBXResourcesBuildPhase;
buildActionMask = 2147483647;
files = (
3E82044D2C13969D00D9BEA1 /* text.riv in Resources */,
3E3DB3592BF5449D000EAA9E /* Preview Assets.xcassets in Resources */,
3E82044C2C13969D00D9BEA1 /* dwarf.riv in Resources */,
3E3DB3552BF5449D000EAA9E /* Assets.xcassets in Resources */,
3E82044E2C13969D00D9BEA1 /* vector.riv in Resources */,
);
runOnlyForDeploymentPostprocessing = 0;
};
Expand Down
2 changes: 1 addition & 1 deletion golden_test_app/golden_test_app/SingleDrawRiveView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ struct GoldenTestViewRepresentable : UIViewRepresentable {
open class SingleDrawRiveView: RiveView {

var currentModelIndex = -1
let modelsToRun = [/*"vector","dwarf", "text"*/]
let modelsToRun = ["vector","dwarf", "text"]
var viewModel: RiveViewModel?
var canRender = 1
var texture: MTLTexture?;
Expand Down
Binary file added golden_test_app/golden_test_app/raws/dwarf.riv
Binary file not shown.
Binary file added golden_test_app/golden_test_app/raws/text.riv
Binary file not shown.
Binary file added golden_test_app/golden_test_app/raws/vector.riv
Binary file not shown.

0 comments on commit 701a1df

Please sign in to comment.