Switch mavis submodule to use HTTPS #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the wrong file may have been added/staged in the commit. I'm seeing I'm happy to help so just let me know if you'd like it! |
|
I will check again ..but will make necessary changes because I had made
changes in .gitmodules only
…On Sun, Aug 11, 2024 at 5:16 AM oms-vmicro ***@***.***> wrote:
It looks like the wrong file may have been added/staged in the commit.
I'm seeing .gitmodules.save in this pull-request when I believe the
intended file to be updated is .gitmodules.
I'm happy to help so just let me know if you'd like it!
—
Reply to this email directly, view it on GitHub
<#195 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5WMIMSXVC3JK3RDGC2LQPLZQ2Q5BAVCNFSM6AAAAABMJT7REKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBSGMYTKOBRGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Respected Sir ,I have made changes pls check it
…On Sun, Aug 11, 2024 at 9:33 AM Shubh Garg ***@***.***> wrote:
I will check again ..but will make necessary changes because I had made
changes in .gitmodules only
On Sun, Aug 11, 2024 at 5:16 AM oms-vmicro ***@***.***>
wrote:
> It looks like the wrong file may have been added/staged in the commit.
>
> I'm seeing .gitmodules.save in this pull-request when I believe the
> intended file to be updated is .gitmodules.
>
> I'm happy to help so just let me know if you'd like it!
>
> —
> Reply to this email directly, view it on GitHub
> <#195 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/A5WMIMSXVC3JK3RDGC2LQPLZQ2Q5BAVCNFSM6AAAAABMJT7REKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBSGMYTKOBRGY>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
|
The change to You'll need to do a |
|
Sir I have fixed ..
…On Mon, Aug 12, 2024 at 9:59 PM oms-vmicro ***@***.***> wrote:
The change to .gitmodules looks good. However, I'm still seeing
.gitmodules.save as a new file in this commit (See
https://github.com/riscv-software-src/riscv-perf-model/pull/195/files).
You'll need to do a git rm .gitmodules.save to remove it from the commit.
—
Reply to this email directly, view it on GitHub
<#195 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5WMIMRXEDMM5UILH7ZB5ALZRDPH7AVCNFSM6AAAAABMJT7REKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBUGQ2TENJSGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
oms-vmicro
approved these changes
Aug 12, 2024
|
Awesome, thanks!
…On Mon, 12 Aug 2024 at 10:10 PM, oms-vmicro ***@***.***> wrote:
***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#195 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5WMIMTELTMXR7Q3JASEDT3ZRDQRVAVCNFSM6AAAAABMJT7REKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMZTGU2TIMRZGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
|
klingaard
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request I have tried to update ".gitmodules" file to switch mavis (submodule) from SSH to HTTPS, this is the change which is user friendly and hassle free cloning for all users, especially for people those who do not have SSH access and prefer HTTPS for real time operations.
Updated the above mentioned file ".gitmodules" to use HTTPS for the mavis submodule:
"https://github.com/sparcians/mavis.git"
Synchronized and reinitialized the mavis submodule to reflect the new URL.
Verified the submodule is correctly cloned and also functional with new integration.
This is a enhancement feature which improves accessibility and ease the process of setting up locally for those w/o SSH credentials.