Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTTPS instead of SSH for submodules? #193

Closed
oms-vmicro opened this issue Aug 5, 2024 · 4 comments · Fixed by #195
Closed

Use HTTPS instead of SSH for submodules? #193

oms-vmicro opened this issue Aug 5, 2024 · 4 comments · Fixed by #195

Comments

@oms-vmicro
Copy link

There have been recent changes to the method riscv-perf-model clones its submodules. Currently it is mixed with stf_lib and fsl using HTTPS and mavis using SSH (link).

I'd like to propose mavis also switch back to using HTTPS so all submodules are cloned in a consistent way. Though I'd like to understand if there's a reason to use SSH over HTTPS and/or do so for mavis but not stf_lib and fsl.

My basis for proposing HTTPS is that It is possible not all consumers of the riscv-perf-model will want to use SSH as I believe that requires them to have a GitHub account. For read-only consumers, HTTPS is sufficient. Non-GitHub users can still get around this by modifying their .gitmodules to use HTTPS instead of SSH but it's another step in getting started.

@jeffnye-gh @kathlenemagnus

@Shubhf
Copy link
Contributor

Shubhf commented Aug 8, 2024

hey @oms-vmicro Can I take up this issue?
I am thinking that switching mavis to HTTPS would be a better option , as it would be a consistent and straightforward access for all users, particularly without git accounts, This not only helps to making it easier for new contributors, and indirectly will be helping new contributors to work with risk-perf-model

@oms-vmicro
Copy link
Author

@Shubhf Yes, please feel free!
I wanted to collect information on if there was a strong need/want to keep SSH. But I'm in favor of HTTPS for the exact reasons you mentioned. I'd say go ahead and if there's any disagreement it'll come up in the pull-request ;)

@klingaard
Copy link
Collaborator

There's no strong need. Feel free to change it.

@Shubhf
Copy link
Contributor

Shubhf commented Aug 10, 2024

I have tried to make necessary changes @klingaard @oms-vmicro Pls review and suggest what all I could do morehttps://github.com/riscv-software-src/riscv-perf-model/pull/195

@klingaard klingaard linked a pull request Aug 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants