-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use HTTPS instead of SSH for submodules? #193
Comments
hey @oms-vmicro Can I take up this issue? |
@Shubhf Yes, please feel free! |
There's no strong need. Feel free to change it. |
I have tried to make necessary changes @klingaard @oms-vmicro Pls review and suggest what all I could do morehttps://github.com/riscv-software-src/riscv-perf-model/pull/195 |
There have been recent changes to the method
riscv-perf-model
clones its submodules. Currently it is mixed withstf_lib
andfsl
using HTTPS andmavis
using SSH (link).I'd like to propose
mavis
also switch back to using HTTPS so all submodules are cloned in a consistent way. Though I'd like to understand if there's a reason to use SSH over HTTPS and/or do so formavis
but notstf_lib
andfsl
.My basis for proposing HTTPS is that It is possible not all consumers of the
riscv-perf-model
will want to use SSH as I believe that requires them to have a GitHub account. For read-only consumers, HTTPS is sufficient. Non-GitHub users can still get around this by modifying their.gitmodules
to use HTTPS instead of SSH but it's another step in getting started.@jeffnye-gh @kathlenemagnus
The text was updated successfully, but these errors were encountered: