Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pointer masking: Fix: Let transformed_addr of fetching be unchanged #1776

Merged
merged 2 commits into from
Aug 18, 2024

Conversation

YenHaoChen
Copy link
Collaborator

The transformation does not apply to implicit accesses such as instruction fetches.

The transformation does not apply to implicit accesses such as instruction fetches.
riscv/mmu.cc Outdated Show resolved Hide resolved
Copy link
Collaborator

@aswaterman aswaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this fix is incomplete; you also need to disable pointer masking when MXR is in effect.

Copy link
Collaborator

@aswaterman aswaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see get_pmlen checks MXR. Nevermind.

Can you fix the coding style about 64 vs. xlen I mentioned in the other comment and ping me afterwards? Then, I'll merge.

@YenHaoChen
Copy link
Collaborator Author

@aswaterman
Commit 0648ab4 fixes the coding style about 64 vs. xlen.

@aswaterman aswaterman merged commit 33d80b4 into riscv-software-src:master Aug 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants