Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report error if an unsupported memory configuration is detected #1111

Conversation

EccoTheDolphin
Copy link

This commit adds error message for the case when an incorrect memory region is
detected. The check for invariant was moved to a separate function to simplify
the code of mem_cfg_t users.

@EccoTheDolphin
Copy link
Author

@scottj97 this PR is a result of our discussion here. Would you kindly review this one?

Copy link
Contributor

@scottj97 scottj97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to take so long. Looks good to me!

@aswaterman aswaterman merged commit 60c0c86 into riscv-software-src:master Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants