Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ISA fields for Zca, CMO, and rv32e rotate tests #419

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

davidharrishmc
Copy link
Contributor

Description

Provide a detailed description of the changes performed by the PR.

Fixed ISA fields to include 32/64 in Zca and CMO tests.
Also fixed ISA fields in rv32e_m/B/src/ror-01 and rori-01 that listed I instead of E.
Note that this fix does not change the bad riscv-ctg .CGF, so if the tests are regenerated, they will have this same bad ISA.

Related Issues

Please list all the issues related to this PR. Use NA if no issues exist
This is similar to the fixes in 410 and 411, but affects the new Zca and CMO tests as well as two EB tests.

Ratified/Unratified Extensions

  • [ x] Ratified
  • Unratified

List Extensions

List the extensions that your PR affects. In case of unratified extensions, please provide a link to the spec draft that was referred to make this PR.

Zca
CMO
EB

Reference Model Used

  • [ x] SAIL
  • [ x] Spike
  • Other - < SPECIFY HERE >

Mandatory Checklist:

  • [ x] All tests are compliant with the test-format spec present in this repo ?
  • [ x] Ran the new tests on RISCOF with SAIL/Spike as reference model successfully ?
  • [n/a ] Ran the new tests on RISCOF in coverage mode
  • [ n/a] Link to Google-Drive folder containing the new coverage reports (See this for more info): < SPECIFY HERE >
  • [n/a ] Link to PR in RISCV-ISAC from which the reports were generated : < SPECIFY HERE >
  • [ x] Changelog entry created with a minor patch

Optional Checklist:

  • RISCV-V CTG PR link if tests were generated using it : Added comment to open PR#22 regarding CMO. The Zca and EB CGFs do not appear to be part of riscv-ctg yet.
  • [y ] Were the tests hand-written/modified ?
  • [ y openhwgroup/cvw] Have you run these on any hard DUT model ? Please specify name and provide link if possible in the description
  • [n ] If you have modified arch_test.h Please provide a detailed description of the changes in the Description section above.

…A fields in rv32e_m/B/src/ror-01 and rori-01 that listed I instead of E.
Copy link
Collaborator

@allenjbaum allenjbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These have been tested, so they don't break anything. It is unclear to me why these changes are needed now when they weren't before, though....

@allenjbaum allenjbaum merged commit c955abf into riscv-non-isa:main Dec 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants