Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server/gdb_server: Step unavailable targets. #924

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Conversation

timsifive
Copy link
Collaborator

@timsifive timsifive commented Sep 27, 2023

When gdb requests to step an unavailable target, pretend the target is still running and the step hasn't yet completed. When the target becomes available, the step can complete.

Change-Id: I969ab56139f72a757552928d59edf6eabd598fa4

When gdb requests to step an unavailable target, report success. When
the target becomes available, the step can complete.

Change-Id: I969ab56139f72a757552928d59edf6eabd598fa4
Signed-off-by: Tim Newsome <[email protected]>
Copy link
Collaborator

@JanMatCodasip JanMatCodasip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks all right to me - checked visually.

src/server/gdb_server.c Show resolved Hide resolved
@JanMatCodasip
Copy link
Collaborator

JanMatCodasip commented Oct 5, 2023

Please consider updating the commit message (for easier reference in the future):

When gdb requests to step an unavailable target, report success. (...)
-->
When gdb requests to step an unavailable target, pretend the target is still running and the step hasn't yet completed. (...)

(or similar wording)

@timsifive
Copy link
Collaborator Author

Fixed the PR description. Thanks.

@timsifive timsifive merged commit 28f630d into riscv Oct 5, 2023
5 checks passed
@timsifive timsifive deleted the unavailable_step branch October 5, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants