Merge pull request #924 from riscv/unavailable_step

server/gdb_server: Step unavailable targets.
riscv-collab · Oct 5, 2023 · 28f630d · 28f630d
2 parents 599e0a2 + 944fe66
commit 28f630d
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/src/server/gdb_server.c b/src/server/gdb_server.c
@@ -3176,9 +3176,15 @@ static bool gdb_handle_vcont_packet(struct connection *connection, const char *p
 			return true;
 		}
 
-		retval = target_step(ct, current_pc, 0, 0);
-		if (retval == ERROR_TARGET_NOT_HALTED)
-			LOG_INFO("target %s was not halted when step was requested", target_name(ct));
+		if (ct->state == TARGET_UNAVAILABLE) {
+			LOG_TARGET_ERROR(ct, "Target is unavailable, so cannot be stepped. "
+					     "Pretending to gdb that it is running until it's available again.");
+			retval = ERROR_FAIL;
+		} else {
+			retval = target_step(ct, current_pc, 0, 0);
+			if (retval == ERROR_TARGET_NOT_HALTED)
+				LOG_INFO("target %s was not halted when step was requested", target_name(ct));
+		}
 
 		/* if step was successful send a reply back to gdb */
 		if (retval == ERROR_OK) {