Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop re-publishing joint states #1

Closed
wants to merge 9 commits into from
Closed

Stop re-publishing joint states #1

wants to merge 9 commits into from

Commits on Oct 27, 2021

  1. Simplify use of arguments 

    No need to declare an intermediate property
    @rhaschke
    rhaschke committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    0fc443e View commit details
    Browse the repository at this point in the history

  2. Place XML comments in front of xacro commands 

    ... to hide them in the final URDF
    @rhaschke
    rhaschke committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    ef9d26e View commit details
    Browse the repository at this point in the history

  3. Fix typo

    @rhaschke
    rhaschke committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    07c9c36 View commit details
    Browse the repository at this point in the history

  4. Simplify use of argument paused 

    ... avoiding code duplication
    @rhaschke
    rhaschke committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    aebcdc6 View commit details
    Browse the repository at this point in the history

  5. Move remap from=equilibrium_pose to the interactive_marker.py node 

    ... to clarify that this node requires the remapping.
    @rhaschke
    rhaschke committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    d78f0e5 View commit details
    Browse the repository at this point in the history

  6. Add 'ns' argument to allow specifying the robotNamespace for Gazebo 

    The robotNamespace is conceptually different from arm_id.
While the latter just acts as a name prefix for links and joints,
the <robotNamespace> tag specifies the name of the ROS namespace, which is used
for key robot components like the joint_states topic, the controller_manager, etc.

To allow for an empty namespace, the default needs to be specified as empty.
Otherwise, i.e. having a non-empty default, specifying ns:="" on the commandline
will fall back to the default despite an (empty) value was provided.
    @rhaschke
    rhaschke committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    f6ac65f View commit details
    Browse the repository at this point in the history

  7. Allow starting the Gazebo robot w/ and w/o a namespace. 

    By default, we don't start in a namespace to match the real-robot behavior.
Unfortunately, we cannot just specify an empty ns="" in roslaunch, but we
need to distinguish the two cases empty/non-empty namespace.
To avoid code duplication, the relevant code was factored out into panda_ns.launch.xml,
which is include w/ or w/o a namespace.
The file-ending is deliberatively choosen as .launch.xml to hide the file from bash completion.
    @rhaschke
    rhaschke committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    affc1f8 View commit details
    Browse the repository at this point in the history

  8. Drop re-publishing joint_states_desired

    @rhaschke
    rhaschke committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    09af9c7 View commit details
    Browse the repository at this point in the history

  9. Replace re-publishing joint_states with remapping

    @rhaschke
    rhaschke committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    afc75a5 View commit details
    Browse the repository at this point in the history