Skip to content

ETH+/ETH collateral feedback #3563

ETH+/ETH collateral feedback

ETH+/ETH collateral feedback #3563

Triggered via pull request May 29, 2024 02:31
Status Success
Total duration 43m 26s
Artifacts

tests.yml

on: pull_request
Deployment Scripts
6m 17s
Deployment Scripts
Lint Checks
17m 47s
Lint Checks
Plugin Unit Tests
5m 28s
Plugin Unit Tests
Plugin Integration Tests (Mainnet) - 1/2
43m 15s
Plugin Integration Tests (Mainnet) - 1/2
Plugin Integration Tests (Mainnet) - 2/2
23m 51s
Plugin Integration Tests (Mainnet) - 2/2
Plugin Integration Tests (Base)
5m 40s
Plugin Integration Tests (Base)
Plugin Integration Tests (Arbitrum)
10m 58s
Plugin Integration Tests (Arbitrum)
P0 tests
17m 9s
P0 tests
P1 Tests
15m 22s
P1 Tests
Scenario Tests
8m 2s
Scenario Tests
Extreme Tests
38m 35s
Extreme Tests
Integration Tests
6m 21s
Integration Tests
Monitor Tests (Mainnet)
3m 17s
Monitor Tests (Mainnet)
Fit to window
Zoom out
Zoom in

Annotations

23 warnings
Monitor Tests (Mainnet)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Plugin Unit Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Plugin Integration Tests (Base)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Deployment Scripts
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Integration Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Scenario Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Plugin Integration Tests (Arbitrum)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
P1 Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
P0 tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Lint Checks
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Lint Checks: contracts/facade/Facade.sol#L30
When fallback is not payable you will not be able to receive ether
Lint Checks: contracts/facade/Facade.sol#L30
Fallback function must be simple
Lint Checks: contracts/facade/Facade.sol#L35
Avoid to use inline assembly. It is acceptable only in rare cases
Lint Checks: contracts/plugins/assets/curve/L2ConvexStableCollateral.sol#L9
Variable name must be in mixedCase
Lint Checks: contracts/plugins/assets/curve/L2ConvexStableCollateral.sol#L10
Variable name must be in mixedCase
Lint Checks: contracts/plugins/assets/curve/PoolTokens.sol#L17
Variable name must be in mixedCase
Lint Checks: contracts/plugins/assets/curve/PoolTokens.sol#L18
Variable name must be in mixedCase
Lint Checks: test/RToken.test.ts#L9
'ONE_PERIOD' is defined but never used
Lint Checks: test/integration/mainnet-test/FacadeActVersion.test.ts#L12
'ONE_PERIOD' is defined but never used
Plugin Integration Tests (Mainnet) - 2/2
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Extreme Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Plugin Integration Tests (Mainnet) - 1/2
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.