ETH+/ETH collateral feedback #3563
Annotations
11 warnings
|
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
contracts/facade/Facade.sol#L30
When fallback is not payable you will not be able to receive ether
|
|
contracts/facade/Facade.sol#L30
Fallback function must be simple
|
|
contracts/facade/Facade.sol#L35
Avoid to use inline assembly. It is acceptable only in rare cases
|
|
contracts/plugins/assets/curve/L2ConvexStableCollateral.sol#L9
Variable name must be in mixedCase
|
|
contracts/plugins/assets/curve/L2ConvexStableCollateral.sol#L10
Variable name must be in mixedCase
|
|
contracts/plugins/assets/curve/L2ConvexStableCollateral.sol#L45
Code contains empty blocks
|
|
contracts/plugins/assets/curve/PoolTokens.sol#L17
Variable name must be in mixedCase
|
|
contracts/plugins/assets/curve/PoolTokens.sol#L18
Variable name must be in mixedCase
|
|
test/RToken.test.ts#L9
'ONE_PERIOD' is defined but never used
|
|
test/integration/mainnet-test/FacadeActVersion.test.ts#L12
'ONE_PERIOD' is defined but never used
|
This job succeeded
Loading