Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for noobaa on client clusters #176

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Add support for noobaa on client clusters #176

merged 1 commit into from
Sep 3, 2024

Conversation

ezio-auditore
Copy link

@ezio-auditore ezio-auditore commented Jul 2, 2024 •
edited
Loading

1.Fetch noobaa remote join secret (noobaa-remote-join-secret-{clusterID}) from the provider server via GetStorageConfig Ref: red-hat-storage/ocs-operator#2680
1. auth_token to be used for authentication with provider noobaa
2. mgmt_addr to be use for getting the address of the provider noobaa server

  1. Creation of the join secret in client clusters noobaa-remote-join-secret
  2. Creation of a remote Noobaa CR referencing the join secret
    Part of RHSTOR-5187

@ezio-auditore ezio-auditore force-pushed the noobaa_obc branch 2 times, most recently from 86cb5f4 to f60ade9 Compare July 17, 2024 13:05
@ezio-auditore ezio-auditore force-pushed the noobaa_obc branch 2 times, most recently from 7ab8de1 to efce591 Compare July 18, 2024 09:00
@ezio-auditore ezio-auditore marked this pull request as ready for review July 18, 2024 09:05
rewantsoni
rewantsoni suggested changes Jul 18, 2024
View reviewed changes
service/status-report/main.go Outdated Show resolved Hide resolved
service/status-report/main.go Outdated Show resolved Hide resolved
rchikatw
rchikatw reviewed Jul 22, 2024
View reviewed changes
controllers/storageclient_controller.go Outdated Show resolved Hide resolved
service/status-report/main.go Outdated Show resolved Hide resolved
service/status-report/main.go Outdated Show resolved Hide resolved
@rchikatw
Copy link
Contributor

It would be beneficial to include testing results and a PR description to avoid the need to navigate through the epic.

@ezio-auditore ezio-auditore force-pushed the noobaa_obc branch 5 times, most recently from 9c35227 to f861fd9 Compare July 22, 2024 18:32
nb-ohad
nb-ohad requested changes Jul 22, 2024
View reviewed changes
controllers/storageclient_controller.go Outdated Show resolved Hide resolved
controllers/storageclient_controller.go Outdated Show resolved Hide resolved
controllers/storageclient_controller.go Outdated Show resolved Hide resolved
service/status-report/main.go Outdated Show resolved Hide resolved
controllers/storageclient_controller.go Outdated Show resolved Hide resolved
rchikatw
rchikatw reviewed Jul 23, 2024
View reviewed changes
controllers/storageclient_controller.go Outdated Show resolved Hide resolved
controllers/storageclient_controller.go Outdated Show resolved Hide resolved
@ezio-auditore ezio-auditore force-pushed the noobaa_obc branch 2 times, most recently from 59c2ff2 to 05e27aa Compare July 23, 2024 06:35
@ezio-auditore ezio-auditore mentioned this pull request Jul 23, 2024
Open
nb-ohad
nb-ohad requested changes Jul 24, 2024
View reviewed changes
controllers/storageclient_controller.go Outdated Show resolved Hide resolved
controllers/storageclient_controller.go Outdated Show resolved Hide resolved
nb-ohad
nb-ohad requested changes Jul 24, 2024
View reviewed changes
controllers/storageclient_controller.go Outdated Show resolved Hide resolved
@nb-ohad
Copy link
Contributor

nb-ohad commented Jul 24, 2024

/lgtm

@openshift-ci openshift-ci bot removed the lgtm label Jul 26, 2024
@nb-ohad
Copy link
Contributor

nb-ohad commented Sep 3, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 3, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ezio-auditore, nb-ohad, rewantsoni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ezio-auditore
Copy link
Author

/unhold

@ezio-auditore
Copy link
Author

/test tide

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 3, 2024

@ezio-auditore: No presubmit jobs available for red-hat-storage/ocs-client-operator@main

In response to this:

/test tide

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 111ba8c into red-hat-storage:main Sep 3, 2024
12 checks passed
@ezio-auditore
Copy link
Author

/cherry-pick release-4.17

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 3, 2024
Merged
@openshift-cherrypick-robot
Copy link

@ezio-auditore: new pull request created: #221

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced Sep 24, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchikatw rchikatw rchikatw left review comments

@leelavg leelavg leelavg left review comments

@rewantsoni rewantsoni rewantsoni requested changes

@rohan47 rohan47 rohan47 left review comments

@nb-ohad nb-ohad nb-ohad requested changes

Assignees

@nb-ohad nb-ohad

@rewantsoni rewantsoni

Labels
approved lgtm size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ezio-auditore @rchikatw @rewantsoni @leelavg @nb-ohad @openshift-cherrypick-robot @rohan47 @openshift-merge-robot