Ignore sending healthchecker & rook-ceph-mon secrets via storageconfig #2828
Conversation
|
@parth-gr: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ezio-auditore
force-pushed
the
remove-mon-secret
branch
from
f5014ea
to
91316d4
Compare
| assert.NoError(t, err) | ||
| assert.NotNil(t, storageConRes) |
There was a problem hiding this comment.
we should not have these changes, please remove secrets from this file related to monitor and health checker
There was a problem hiding this comment.
For the current change since the health checker and monitor secrets are not getting created , the test condition when StorageConsumerState is ready it need not have cephresources and can be empty. It should not return an error and the storageconfig should not be empty
There was a problem hiding this comment.
Yes, we need to remove those as well as a follow-up but not a must-have for now.
There was a problem hiding this comment.
Tracking in this #2829
Signed-off-by: Kaustav Majumder <[email protected]>
ezio-auditore
force-pushed
the
remove-mon-secret
branch
from
91316d4
to
4f849d2
Compare
|
LGTM /assign @leelavg for another ack |
|
@Madhu-1: GitHub didn't allow me to assign the following users: for, another, ack. Note that only red-hat-storage members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ezio-auditore, iamniting, leelavg, parth-gr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/cherry-pick release-4.17 |
|
@iamniting: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit 7de48ec
into
red-hat-storage:main
|
@iamniting: new pull request created: #2830 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The ceph health checker secret and the rook-ceph-mon secrets to configure cephclients are not being used anymore but they are being sent via GetStorageConfig grpc. These secrets were being created and since they lacked permissions to run ceph commands the cephclients were in failure state. This PR removes these secrets from being sent to storageclients.
The secrets were being created by ocs-client operator and were introduced in this PR, red-hat-storage/ocs-client-operator#176