Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade the notebook images with 2023b and 2023a images #513

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Upgrade the notebook images with 2023b and 2023a images #513

wants to merge 1 commit into from

Conversation

harshad16
Copy link
Member

@harshad16 harshad16 commented Oct 21, 2023 •
edited
Loading

Upgrade the notebook images with 2023b and 2023a images
Related-to: opendatahub-io/notebooks#273

In-repo update of manifests: red-hat-data-services/notebooks#62

This was referenced Oct 21, 2023
Closed
Closed
atheo89
atheo89 requested changes Oct 23, 2023
View reviewed changes
Copy link
Member

@atheo89 atheo89 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are on the finish line! Added some comments and suggestions to this review.
The main observation is that we need to update the versions within the notebook-python-dependencies annotation for the majority of ImageStreams.

@atheo89 atheo89 mentioned this pull request Oct 23, 2023
Closed
8 tasks
@atheo89
Copy link
Member

atheo89 commented Oct 23, 2023

This is the related PR on the Upstream notebooks repo -> opendatahub-io/notebooks#270

@harshad16 harshad16 force-pushed the patch-2023b-images branch 3 times, most recently from a47a5d7 to 560e099 Compare October 23, 2023 13:23
@harshad16 harshad16 force-pushed the patch-2023b-images branch 3 times, most recently from 7d1e5b6 to 316a22c Compare October 23, 2023 14:26
@atheo89
Copy link
Member

atheo89 commented Oct 23, 2023

/lgtm

@atheo89
Copy link
Member

atheo89 commented Oct 24, 2023

After modifying the structure of params.env to align with the new release, you can also access the latest version of the digest updater in this open pull request -> #509

This was referenced Oct 27, 2023
Closed
Closed
@harshad16
Copy link
Member Author

The Notebook manifests would not be used from the odh-manifests.
This is a final upgrade, just to keep in the line in-repo manifests and included 2023b
in case , anyone uses this repo.

@harshad16
Copy link
Member Author

/approve

VaishnaviHire
VaishnaviHire approved these changes Oct 27, 2023
View reviewed changes
Copy link

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@atheo89
Copy link
Member

atheo89 commented Oct 30, 2023

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atheo89 atheo89 atheo89 requested changes

@VaishnaviHire VaishnaviHire VaishnaviHire approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harshad16 @atheo89 @VaishnaviHire