Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo on annotations into image streams [Master] #501

Closed
wants to merge 1 commit into from
Closed

Fix typo on annotations into image streams [Master] #501

wants to merge 1 commit into from

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Oct 3, 2023

Fix typo on annotations
Related-to: opendatahub-io/notebooks#207

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • For commits that came from upstream, [UPSTREAM] has been prepended to the commit message
  • JIRA link(s):
  • The Jira story is acked
  • An entry has been added to the latest build document in Build Announcements Folder.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious)

@atheo89 atheo89 requested a review from harshad16 October 3, 2023 16:08
harshad16
harshad16 approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks 💯

@harshad16
Copy link
Member

Thank you for the exactly effort.
Closing this in favor of #513.
That PR would take over.

@harshad16 harshad16 closed this Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshad16 harshad16 harshad16 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atheo89 @harshad16