-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHOAI: Build VSCode notebook on RHEL9 base #94
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @atheo89, thank you for this. I've put a few comments here. Otherwise LGTM.
@@ -16,3 +16,4 @@ odh-tensorflow-gpu-notebook-image-n-2=quay.io/modh/cuda-notebooks@sha256:6fadedc | |||
odh-trustyai-notebook-image-n=quay.io/modh/odh-trustyai-notebook@sha256:b68c1bfd9926b224180835382b36ad25e2269ffb95fca0646a89c8cceb6a6e7a | |||
odh-trustyai-notebook-image-n-1=quay.io/modh/odh-trustyai-notebook@sha256:de46659eccc3dd8e4b79cfbf7fc95464f76ffcc06f3f914841533130fba2985f | |||
odh-habana-notebook-image-n=quay.io/modh/odh-habana-notebooks@sha256:0f6ae8f0b1ef11896336e7f8611e77ccdb992b49a7942bf27e6bc64d73205d05 | |||
odh-codeserver-notebook-n=quay.io/modh/codeserver@sha256: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose that this is something that is gonna be updated later, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly, i will open a follow up PR to fill this value. Once this PR get merged the CI will build the image and eventually I will be able to use it on the params.env
/hold Checking the case if we can build the VSCode based on UBI9 on upstream and downstream,in favor of less maintenance and help QE to test it earlier on upstream first. |
@atheo89: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Seems the rebase to UBI9 it works well. |
Closing this since we were able to build code server notebook based on UBI9 base image, so no need to keep this open. |
Ref. Issue: opendatahub-io#283
Depend on: openshift/release#45089
This PR incorporates the VSCode notebook to RHOAI.
How has been tested:
The behavior of the notebook looks the same as the one based on C9S in ODH.
The RHEL base image that used is : https://catalog.redhat.com/software/containers/rhel9/python-39/61a6101fbfd4a5234d59629d?architecture=amd64&image=65301f5a53a51a886582fba1
1. On a Local Run
make codeserver-rhel9-python-3.9
podman run --network=host --name validation-container quay.io/rh_ee_atheodor/workbench-images:codeserver-rhel9-python-3.9-2023b_20231106
Once you finish the inspection:
podman stop validation-container && podman rm validation-container
2. On the Cluster
Deploy on the cluster:
make deploy-rhel9-codeserver-rhel9-python-3.9
Run the Test:
make validate-codeserver-image image=codeserver-rhel9-python-3.9-2023b_20231106
ensure that the test completed successfullyUndeploy:
make undeploy-rhel9-codeserver-rhel9-python-3.9